diff options
| author | Samuel Attard <sattard@slack-corp.com> | 2019-07-17 00:45:29 +0300 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2019-07-21 22:21:23 +0300 |
| commit | 8b344ae4c23ad6bd2a3e2927e95595011c1ff289 (patch) | |
| tree | 395f1d19ad56e9259a58f13537ac9de731d96b15 /src/tracing | |
| parent | 6948a95562884636fdbf9627069e3ebc801a71ec (diff) | |
src: expose TraceEventHelper with NODE_EXTERN
As node requires a tracing controller to be initialized embedders need
access to the TraceEventHelper so that we can actually set the tracing
controller.
Refs: https://github.com/electron/electron/commit/0e5b6f93000e4718c9e35332ddbd0f6b76cdd585/#diff-89b287b2edd0a02dddae60cb26157f47
PR-URL: https://github.com/nodejs/node/pull/28724
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Diffstat (limited to 'src/tracing')
| -rw-r--r-- | src/tracing/trace_event.h | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/tracing/trace_event.h b/src/tracing/trace_event.h index 590cb592fc0..27408eafd83 100644 --- a/src/tracing/trace_event.h +++ b/src/tracing/trace_event.h @@ -310,7 +310,9 @@ const int kZeroNumArgs = 0; const decltype(nullptr) kGlobalScope = nullptr; const uint64_t kNoId = 0; -class TraceEventHelper { +// Extern (for now) because embedders need access to TraceEventHelper. +// Refs: https://github.com/nodejs/node/pull/28724 +class NODE_EXTERN TraceEventHelper { public: static TracingController* GetTracingController(); static Agent* GetAgent(); |