diff options
| author | Anna Henningsen <anna@addaleax.net> | 2019-11-08 21:40:46 +0300 |
|---|---|---|
| committer | Myles Borins <mylesborins@google.com> | 2019-11-21 08:29:26 +0300 |
| commit | 1a92c884185bc3e01c6d64aae55ea5a947d82840 (patch) | |
| tree | df5f0a195866bf94bf0f7d90827817adfb859f1e /src/util-inl.h | |
| parent | f17c794faf7892ee385d10bba8c11c9df4b45778 (diff) | |
src: migrate off ArrayBuffer::GetContents
V8 deprecates `GetContents()` in favour of `GetBackingStore()`.
Update our code to reflect that.
V8 also deprecates `Externalize()` and `IsExternal()`; we should
be able to remove all usage of this once V8 8.0 is there.
PR-URL: https://github.com/nodejs/node/pull/30339
Refs: https://github.com/v8/v8/commit/bfe3d6bce734e596e312465e207bcfd55a59fe34
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Diffstat (limited to 'src/util-inl.h')
| -rw-r--r-- | src/util-inl.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/util-inl.h b/src/util-inl.h index c06a0ae84c8..d44ee09fefb 100644 --- a/src/util-inl.h +++ b/src/util-inl.h @@ -514,7 +514,7 @@ void ArrayBufferViewContents<T, S>::Read(v8::Local<v8::ArrayBufferView> abv) { static_assert(sizeof(T) == 1, "Only supports one-byte data at the moment"); length_ = abv->ByteLength(); if (length_ > sizeof(stack_storage_) || abv->HasBuffer()) { - data_ = static_cast<T*>(abv->Buffer()->GetContents().Data()) + + data_ = static_cast<T*>(abv->Buffer()->GetBackingStore()->Data()) + abv->ByteOffset(); } else { abv->CopyContents(stack_storage_, sizeof(stack_storage_)); |