diff options
| author | Sam Roberts <vieuxtech@gmail.com> | 2019-04-10 01:21:36 +0300 |
|---|---|---|
| committer | Sam Roberts <vieuxtech@gmail.com> | 2019-04-12 22:33:37 +0300 |
| commit | 060d901f87b3d87314f8540eb02f315e2952f581 (patch) | |
| tree | 53159171201703bb6d8a4e780c8624a5c6c8cbb5 /src/util.h | |
| parent | 7b0d8673898e65a368108264c77bccaa3e004028 (diff) | |
src: replace FromJust() with Check() when possible
FromJust() is often used not for its return value, but for its
side-effects. In these cases, Check() exists, and is more clear as to
the intent. From its comment:
To be used, where the actual value of the Maybe is not needed, like
Object::Set.
See: https://github.com/nodejs/node/pull/26929/files#r269256335
PR-URL: https://github.com/nodejs/node/pull/27162
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Diffstat (limited to 'src/util.h')
| -rw-r--r-- | src/util.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/util.h b/src/util.h index a9de8f8636c..7d371809cba 100644 --- a/src/util.h +++ b/src/util.h @@ -582,7 +582,7 @@ inline v8::MaybeLocal<v8::Value> ToV8Value(v8::Local<v8::Context> context, do { \ obj->DefineOwnProperty( \ context, FIXED_ONE_BYTE_STRING(isolate, name), value, v8::ReadOnly) \ - .FromJust(); \ + .Check(); \ } while (0) #define READONLY_DONT_ENUM_PROPERTY(obj, name, var) \ @@ -592,7 +592,7 @@ inline v8::MaybeLocal<v8::Value> ToV8Value(v8::Local<v8::Context> context, OneByteString(isolate, name), \ var, \ static_cast<v8::PropertyAttribute>(v8::ReadOnly | v8::DontEnum)) \ - .FromJust(); \ + .Check(); \ } while (0) #define READONLY_FALSE_PROPERTY(obj, name) \ @@ -621,7 +621,7 @@ inline v8::MaybeLocal<v8::Value> ToV8Value(v8::Local<v8::Context> context, constant_name, \ constant_value, \ constant_attributes) \ - .FromJust(); \ + .Check(); \ } while (0) enum Endianness { |