diff options
author | Jiajie Hu <jiajie.hu@intel.com> | 2017-07-24 05:17:28 +0300 |
---|---|---|
committer | Refael Ackermann <refack@gmail.com> | 2017-07-30 01:00:56 +0300 |
commit | 5796e44827ffcbeaf4a4170a286d6f64a382d58a (patch) | |
tree | dcdc71f1aeffc153491ca44680ec7d43b4b410a8 /src | |
parent | 85a5e5a1f29246f7386f43ea280f2fe0e6ad053a (diff) |
buffer: remove a wrongly added attribute specifier
It doesn't seem to make much sense to have the mentioned typedef
declaration equipped with NODE_EXTERN. In fact, when compiling with GCC,
an attribute specifier like __attribute__((visibility("default"))) in
such a typedef declaration will cause the following warning message:
warning: ‘visibility’ attribute ignored [-Wattributes]
The issue goes unnoticed because NODE_EXTERN is defined as nothing for
GCC builds, but for correctness it's better to not specify it here at
all.
PR-URL: https://github.com/nodejs/node/pull/14466
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Diffstat (limited to 'src')
-rw-r--r-- | src/node_buffer.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/node_buffer.h b/src/node_buffer.h index 799d05a7aa6..acf9b23c3b3 100644 --- a/src/node_buffer.h +++ b/src/node_buffer.h @@ -34,7 +34,7 @@ namespace Buffer { static const unsigned int kMaxLength = sizeof(int32_t) == sizeof(intptr_t) ? 0x3fffffff : 0x7fffffff; -NODE_EXTERN typedef void (*FreeCallback)(char* data, void* hint); +typedef void (*FreeCallback)(char* data, void* hint); NODE_EXTERN bool HasInstance(v8::Local<v8::Value> val); NODE_EXTERN bool HasInstance(v8::Local<v8::Object> val); |