diff options
author | James M Snell <jasnell@gmail.com> | 2020-08-07 02:45:37 +0300 |
---|---|---|
committer | James M Snell <jasnell@gmail.com> | 2020-08-17 21:23:23 +0300 |
commit | 1e6e5c3ef33112f8cec97ab700411b93adf26baf (patch) | |
tree | c68e0477c85605ae71b83475d3ea39e44350e6c7 /src | |
parent | 8b818cf92515e77138e14dd2819856c3414c132e (diff) |
quic: resolve minor TODO in QuicSocket
PR-URL: https://github.com/nodejs/node/pull/34655
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Diffstat (limited to 'src')
-rw-r--r-- | src/quic/node_quic_socket.cc | 11 |
1 files changed, 2 insertions, 9 deletions
diff --git a/src/quic/node_quic_socket.cc b/src/quic/node_quic_socket.cc index 0e054619df8..cf7b128bb00 100644 --- a/src/quic/node_quic_socket.cc +++ b/src/quic/node_quic_socket.cc @@ -472,14 +472,7 @@ void QuicSocket::OnReceive( QuicCID dcid(pdcid, pdcidlen); QuicCID scid(pscid, pscidlen); - // TODO(@jasnell): It would be fantastic if Debug() could be - // modified to accept objects with a ToString-like capability - // similar to what we can do with TraceEvents... that would - // allow us to pass the QuicCID directly to Debug and have it - // converted to hex only if the category is enabled so we can - // skip committing resources here. - std::string dcid_hex = dcid.ToString(); - Debug(this, "Received a QUIC packet for dcid %s", dcid_hex.c_str()); + Debug(this, "Received a QUIC packet for dcid %s", dcid); BaseObjectPtr<QuicSession> session = FindSession(dcid); @@ -489,7 +482,7 @@ void QuicSocket::OnReceive( // 3. The packet is a stateless reset sent by the peer // 4. This is a malicious or malformed packet. if (!session) { - Debug(this, "There is no existing session for dcid %s", dcid_hex.c_str()); + Debug(this, "There is no existing session for dcid %s", dcid); bool is_short_header = IsShortHeader(pversion, pscid, pscidlen); // Handle possible reception of a stateless reset token... |