Welcome to mirror list, hosted at ThFree Co, Russian Federation.

github.com/nodejs/node.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorJames M Snell <jasnell@gmail.com>2020-08-07 03:00:31 +0300
committerJames M Snell <jasnell@gmail.com>2020-08-17 21:23:25 +0300
commit34165f03aa33d58c1a4fbbad0b2c3306a97b0657 (patch)
tree354f625672f8133c3e36f6888904ddd501b62d8d /src
parent1e6e5c3ef33112f8cec97ab700411b93adf26baf (diff)
quic: resolve some minor TODOs
PR-URL: https://github.com/nodejs/node/pull/34655 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
Diffstat (limited to 'src')
-rw-r--r--src/quic/node_quic_session.cc9
1 files changed, 5 insertions, 4 deletions
diff --git a/src/quic/node_quic_session.cc b/src/quic/node_quic_session.cc
index 5bffad8a4fa..999dbd71fda 100644
--- a/src/quic/node_quic_session.cc
+++ b/src/quic/node_quic_session.cc
@@ -3378,8 +3378,10 @@ int QuicSession::OnStreamReset(
// sensitivity of PATH_CHALLENGE operations (an attacker
// could use a compromised PATH_CHALLENGE to trick an endpoint
// into redirecting traffic).
-// TODO(@jasnell): In the future, we'll want to explore whether
-// we want to handle the different cases of ngtcp2_rand_ctx
+//
+// The ngtcp2_rand_ctx tells us what the random data is used for.
+// Currently, there is only one use. In the future, we'll want to
+// explore whether we want to handle the different cases uses.
int QuicSession::OnRand(
ngtcp2_conn* conn,
uint8_t* dest,
@@ -3744,8 +3746,7 @@ void QuicSessionSilentClose(const FunctionCallbackInfo<Value>& args) {
session->Close(QuicSessionListener::SESSION_CLOSE_FLAG_SILENT);
}
-// TODO(addaleax): This is a temporary solution for testing and should be
-// removed later.
+// This is used purely for testing.
void QuicSessionRemoveFromSocket(const FunctionCallbackInfo<Value>& args) {
QuicSession* session;
ASSIGN_OR_RETURN_UNWRAP(&session, args.Holder());