diff options
| author | Yash Ladha <yashladhapankajladha123@gmail.com> | 2021-01-30 11:55:32 +0300 |
|---|---|---|
| committer | Danielle Adams <adamzdanielle@gmail.com> | 2021-02-16 17:12:46 +0300 |
| commit | a6053dc14a99aa98f0440707e0912d0a0b423e3a (patch) | |
| tree | 3241ef3243f2a197bedb166e92253f0b5ab6f8ac /src | |
| parent | 354df9e8a179778d709a91e023a8f790c05aa0c5 (diff) | |
src: add context for TODO comment in env.cc
Add more context around the TODO change required for achieving the
task. When destructuring the isolate and environment_vars from the
environment object, it is leading to recursive dependency and thus not
able to refactor it in a better way.
PR-URL: https://github.com/nodejs/node/pull/37140
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Diffstat (limited to 'src')
| -rw-r--r-- | src/env.cc | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/env.cc b/src/env.cc index 91789c3476f..49d8ffd3130 100644 --- a/src/env.cc +++ b/src/env.cc @@ -372,7 +372,8 @@ Environment::Environment(IsolateData* isolate_data, set_env_vars(per_process::system_environment); // TODO(joyeecheung): pass Isolate* and env_vars to it instead of the entire - // env + // env, when the recursive dependency inclusion in "debug-utils.h" is + // resolved. enabled_debug_list_.Parse(this); // We create new copies of the per-Environment option sets, so that it is |