Welcome to mirror list, hosted at ThFree Co, Russian Federation.

github.com/nodejs/node.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorMichaƫl Zasso <targos@protonmail.com>2022-05-07 01:32:42 +0300
committerRafaelGSS <rafael.nunu@hotmail.com>2022-05-10 15:13:19 +0300
commit38e4c1553407ba0317cc0c640535dc9cdec9410d (patch)
tree44b663d345d826cd34e1b0b888b60e697d4444c3 /src
parent5470578008023f426f0ace07a192c81256c889d9 (diff)
src: always signal V8 for intercepted properties
Closes: https://github.com/nodejs/node/issues/42962 PR-URL: https://github.com/nodejs/node/pull/42963 Fixes: https://github.com/nodejs/node/issues/42962 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Diffstat (limited to 'src')
-rw-r--r--src/node_contextify.cc10
1 files changed, 1 insertions, 9 deletions
diff --git a/src/node_contextify.cc b/src/node_contextify.cc
index 482c9a7b51d..b2df392697c 100644
--- a/src/node_contextify.cc
+++ b/src/node_contextify.cc
@@ -449,16 +449,8 @@ void ContextifyContext::PropertySetterCallback(
!is_function)
return;
- if (!is_declared_on_global_proxy && is_declared_on_sandbox &&
- args.ShouldThrowOnError() && is_contextual_store && !is_function) {
- // The property exists on the sandbox but not on the global
- // proxy. Setting it would throw because we are in strict mode.
- // Don't attempt to set it by signaling that the call was
- // intercepted. Only change the value on the sandbox.
- args.GetReturnValue().Set(false);
- }
-
USE(ctx->sandbox()->Set(context, property, value));
+ args.GetReturnValue().Set(value);
}
// static