diff options
| author | Ben Noordhuis <info@bnoordhuis.nl> | 2018-01-20 03:00:34 +0300 |
|---|---|---|
| committer | Ruben Bridgewater <ruben@bridgewater.de> | 2018-01-21 04:19:46 +0300 |
| commit | d9b59def72c718aaad3eefb6bf43f409ccefe4d2 (patch) | |
| tree | ec02442a3153500b91e368c873db4d1a3763e567 /test/addons-napi/test_object | |
| parent | c6682636be4955e2181c00e7d4868fbf6682a5c5 (diff) | |
build,test: make building addon tests less fragile
* Get rid of recursive `make` when building the node binary. An earlier
commit makes GYP write out rules that we can use for proper dependency
tracking.
* Use module name 'binding' in addons.md and addons-napi/*/binding.gyp.
This massively simplifies the logic for generating the build rules.
* Check in auto-generated add-on tests from `doc/api/addons.md`. The
files change rarely and generating them dynamically causes no end of
race conditions and special-casing during the build.
PR-URL: https://github.com/nodejs/node/pull/17407
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Diffstat (limited to 'test/addons-napi/test_object')
| -rw-r--r-- | test/addons-napi/test_object/binding.gyp | 2 | ||||
| -rw-r--r-- | test/addons-napi/test_object/test.js | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/test/addons-napi/test_object/binding.gyp b/test/addons-napi/test_object/binding.gyp index be225ace779..f589ab92fab 100644 --- a/test/addons-napi/test_object/binding.gyp +++ b/test/addons-napi/test_object/binding.gyp @@ -1,7 +1,7 @@ { "targets": [ { - "target_name": "test_object", + "target_name": "binding", "sources": [ "test_object.c" ] } ] diff --git a/test/addons-napi/test_object/test.js b/test/addons-napi/test_object/test.js index 8e44a1b5ed6..13defcc512a 100644 --- a/test/addons-napi/test_object/test.js +++ b/test/addons-napi/test_object/test.js @@ -3,7 +3,7 @@ const common = require('../../common'); const assert = require('assert'); // Testing api calls for objects -const test_object = require(`./build/${common.buildType}/test_object`); +const test_object = require(`./build/${common.buildType}/binding`); const object = { |