test: add eslint rule to verify assertion input

The input for `assert.deepStrictEqual` and similar expect the actual
input first and the expected input as second argument. This verifies
that this is actually done correct in our tests.

This is important so the possible error message actually makes sense.

PR-URL: https://github.com/nodejs/node/pull/20718
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

1 files changed, 4 insertions, 4 deletions

diff --git a/test/addons-napi/test_conversions/test.js b/test/addons-napi/test_conversions/test.js
index 73d2c3314f6..27e1fb322c4 100644
--- a/test/addons-napi/test_conversions/test.js
+++ b/test/addons-napi/test_conversions/test.js
@@ -118,10 +118,10 @@ assert.deepStrictEqual(new String(''), test.toObject(''));
 assert.deepStrictEqual(new Number(0), test.toObject(0));
 assert.deepStrictEqual(new Number(Number.NaN), test.toObject(Number.NaN));
 assert.deepStrictEqual(new Object(testSym), test.toObject(testSym));
-assert.notDeepStrictEqual(false, test.toObject(false));
-assert.notDeepStrictEqual(true, test.toObject(true));
-assert.notDeepStrictEqual('', test.toObject(''));
-assert.notDeepStrictEqual(0, test.toObject(0));
+assert.notDeepStrictEqual(test.toObject(false), false);
+assert.notDeepStrictEqual(test.toObject(true), true);
+assert.notDeepStrictEqual(test.toObject(''), '');
+assert.notDeepStrictEqual(test.toObject(0), 0);
 assert.ok(!Number.isNaN(test.toObject(Number.NaN)));
 
 assert.strictEqual('', test.toString(''));