Welcome to mirror list, hosted at ThFree Co, Russian Federation.

github.com/nodejs/node.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
path: root/test
diff options
context:
space:
mode:
authorBryan English <bryan@bryanenglish.com>2021-05-26 06:52:45 +0300
committerBryan English <bryan@bryanenglish.com>2021-06-02 17:56:29 +0300
commita172397237af2dbc0c28af45f9edf067c9df544f (patch)
tree7386305ee0b679da598e088555190777a7a3fa47 /test
parent3ec7f300c1633d0cbf081e0366858d373e008fdc (diff)
src: set PromiseHooks by Environment
The new JS PromiseHooks introduced in the referenced PR are per v8::Context. This meant that code depending on them, such as AsyncLocalStorage, wouldn't behave correctly across vm.Context instances. PromiseHooks are now synchronized across the main Context and any Context created via vm.Context. Refs: https://github.com/nodejs/node/pull/36394 Fixes: https://github.com/nodejs/node/issues/38781 Signed-off-by: Bryan English <bryan@bryanenglish.com> PR-URL: https://github.com/nodejs/node/pull/38821 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Diffstat (limited to 'test')
-rw-r--r--test/parallel/test-async-local-storage-contexts.js35
1 files changed, 35 insertions, 0 deletions
diff --git a/test/parallel/test-async-local-storage-contexts.js b/test/parallel/test-async-local-storage-contexts.js
new file mode 100644
index 00000000000..9a632713379
--- /dev/null
+++ b/test/parallel/test-async-local-storage-contexts.js
@@ -0,0 +1,35 @@
+'use strict';
+
+require('../common');
+const assert = require('assert');
+const vm = require('vm');
+const { AsyncLocalStorage } = require('async_hooks');
+
+// Regression test for https://github.com/nodejs/node/issues/38781
+
+const context = vm.createContext({
+ AsyncLocalStorage,
+ assert
+});
+
+vm.runInContext(`
+ const storage = new AsyncLocalStorage()
+ async function test() {
+ return storage.run({ test: 'vm' }, async () => {
+ assert.strictEqual(storage.getStore().test, 'vm');
+ await 42;
+ assert.strictEqual(storage.getStore().test, 'vm');
+ });
+ }
+ test()
+`, context);
+
+const storage = new AsyncLocalStorage();
+async function test() {
+ return storage.run({ test: 'main context' }, async () => {
+ assert.strictEqual(storage.getStore().test, 'main context');
+ await 42;
+ assert.strictEqual(storage.getStore().test, 'main context');
+ });
+}
+test();