diff options
author | Ben Noordhuis <info@bnoordhuis.nl> | 2012-03-09 18:35:50 +0400 |
---|---|---|
committer | Ben Noordhuis <info@bnoordhuis.nl> | 2012-03-10 02:57:03 +0400 |
commit | 8c02f9b7c844909cf5977d065b793c99eb0f9c45 (patch) | |
tree | 502f4d08b899802c99ae30b07ffc945f7ee71b74 /test | |
parent | 2589d5561191ac58f5c87efa796457c9936de73f (diff) |
buffer: throw from constructor if length > kMaxLength
Throw, don't abort. `new Buffer(0x3fffffff + 1)` used to bring down the process
with the following error message:
FATAL ERROR: v8::Object::SetIndexedPropertiesToExternalArrayData() length
exceeds max acceptable value
Fixes #2280.
Diffstat (limited to 'test')
-rw-r--r-- | test/pummel/test-buffer-big.js | 29 |
1 files changed, 29 insertions, 0 deletions
diff --git a/test/pummel/test-buffer-big.js b/test/pummel/test-buffer-big.js new file mode 100644 index 00000000000..8a26c4eb182 --- /dev/null +++ b/test/pummel/test-buffer-big.js @@ -0,0 +1,29 @@ +// Copyright Joyent, Inc. and other Node contributors. +// +// Permission is hereby granted, free of charge, to any person obtaining a +// copy of this software and associated documentation files (the +// "Software"), to deal in the Software without restriction, including +// without limitation the rights to use, copy, modify, merge, publish, +// distribute, sublicense, and/or sell copies of the Software, and to permit +// persons to whom the Software is furnished to do so, subject to the +// following conditions: +// +// The above copyright notice and this permission notice shall be included +// in all copies or substantial portions of the Software. +// +// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS +// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF +// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN +// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, +// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR +// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE +// USE OR OTHER DEALINGS IN THE SOFTWARE. + +var common = require('../common'); +var assert = require('assert'); + +// The tests below should throw an error, not abort the process... +assert.throws(function() { new Buffer(0x3fffffff + 1) }, RangeError); +assert.throws(function() { new Int8Array(0x3fffffff + 1) }, RangeError); +assert.throws(function() { new ArrayBuffer(0x3fffffff + 1) }, RangeError); +assert.throws(function() { new Float64Array(0x7ffffff + 1) }, RangeError); |