Welcome to mirror list, hosted at ThFree Co, Russian Federation.

github.com/nodejs/node.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
path: root/test
diff options
context:
space:
mode:
authorBryan English <bryan@bryanenglish.com>2021-05-26 06:52:45 +0300
committerDanielle Adams <adamzdanielle@gmail.com>2021-06-02 20:22:17 +0300
commit7ba305552f2f2a4ad3a5b33fed1f1d8393b783a4 (patch)
treee1612b00888aceac81485fa95285d00b4d9e9391 /test
parentf1628960e10cadda5d8bb12b9e42a97f057f7cd5 (diff)
src: set PromiseHooks by Environment
The new JS PromiseHooks introduced in the referenced PR are per v8::Context. This meant that code depending on them, such as AsyncLocalStorage, wouldn't behave correctly across vm.Context instances. PromiseHooks are now synchronized across the main Context and any Context created via vm.Context. Refs: https://github.com/nodejs/node/pull/36394 Fixes: https://github.com/nodejs/node/issues/38781 Signed-off-by: Bryan English <bryan@bryanenglish.com> PR-URL: https://github.com/nodejs/node/pull/38821 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Diffstat (limited to 'test')
-rw-r--r--test/parallel/test-async-local-storage-contexts.js35
1 files changed, 35 insertions, 0 deletions
diff --git a/test/parallel/test-async-local-storage-contexts.js b/test/parallel/test-async-local-storage-contexts.js
new file mode 100644
index 00000000000..9a632713379
--- /dev/null
+++ b/test/parallel/test-async-local-storage-contexts.js
@@ -0,0 +1,35 @@
+'use strict';
+
+require('../common');
+const assert = require('assert');
+const vm = require('vm');
+const { AsyncLocalStorage } = require('async_hooks');
+
+// Regression test for https://github.com/nodejs/node/issues/38781
+
+const context = vm.createContext({
+ AsyncLocalStorage,
+ assert
+});
+
+vm.runInContext(`
+ const storage = new AsyncLocalStorage()
+ async function test() {
+ return storage.run({ test: 'vm' }, async () => {
+ assert.strictEqual(storage.getStore().test, 'vm');
+ await 42;
+ assert.strictEqual(storage.getStore().test, 'vm');
+ });
+ }
+ test()
+`, context);
+
+const storage = new AsyncLocalStorage();
+async function test() {
+ return storage.run({ test: 'main context' }, async () => {
+ assert.strictEqual(storage.getStore().test, 'main context');
+ await 42;
+ assert.strictEqual(storage.getStore().test, 'main context');
+ });
+}
+test();