diff options
author | Ryan Dahl <ry@tinyclouds.org> | 2010-11-17 03:26:55 +0300 |
---|---|---|
committer | Ryan Dahl <ry@tinyclouds.org> | 2010-11-17 03:26:55 +0300 |
commit | cea3a95f9fe6faaa504542d4f03349739d08a0f3 (patch) | |
tree | 87aee528b89821940c7a9cc7b7f13a1479f0edbf /test | |
parent | cf05257fb76ab41cccf8c54b923e93d6841b91ca (diff) |
Add ref to buffer during fs.write and fs.read
There was the possibility the buffer could be GCed while the eio_req was
pending. Still needs test coverage for the fs.read() problem.
See:
http://groups.google.com/group/nodejs/browse_thread/thread/c11f8b683f37cef
Diffstat (limited to 'test')
-rw-r--r-- | test/simple/test-fs-sir-writes-alot.js | 50 |
1 files changed, 50 insertions, 0 deletions
diff --git a/test/simple/test-fs-sir-writes-alot.js b/test/simple/test-fs-sir-writes-alot.js new file mode 100644 index 00000000000..004585f8ee5 --- /dev/null +++ b/test/simple/test-fs-sir-writes-alot.js @@ -0,0 +1,50 @@ +var common = require('../common'); +var fs = require("fs"); +var assert = require("assert"); +var join = require('path').join; + +var filename = join(common.tmpDir, 'out.txt'); + +try { + fs.unlinkSync(filename); +} catch (e) { + // might not exist, that's okay. +} + +var fd = fs.openSync(filename, "w"); + +var line = "aaaaaaaaaaaaaaaaaaaaaaaaaaaa\n"; + +var N = 10240, complete = 0; +for (var i = 0; i < N; i ++) { + // Create a new buffer for each write. Before the write is actually + // executed by the thread pool, the buffer will be collected. + var buffer = new Buffer(line); + fs.write(fd, buffer, 0, buffer.length, null, function (er, written) { + complete++; + if (complete === N) { + fs.closeSync(fd); + var s = fs.createReadStream(filename); + s.on("data", testBuffer); + } + }); +} + +var bytesChecked = 0; + +function testBuffer (b) { + for (var i = 0; i < b.length; i++) { + bytesChecked++; + if (b[i] !== 'a'.charCodeAt(0) && b[i] !== '\n'.charCodeAt(0)) { + throw new Error("invalid char "+i+","+b[i]); + } + } +} + +process.on('exit', function () { + // Probably some of the writes are going to overlap, so we can't assume + // that we get (N * line.length). Let's just make sure we've checked a + // few... + assert.ok(bytesChecked > 1000); +}); + |