diff options
author | Nancy Truong <truongh.nancy@gmail.com> | 2018-10-12 20:23:36 +0300 |
---|---|---|
committer | Myles Borins <mylesborins@google.com> | 2018-11-29 19:38:57 +0300 |
commit | 232fe58a4cf67edad4f5c3a83104c2cfa5335451 (patch) | |
tree | 5f2ccc086e3e5b904c6dcd4ac90775f528e40b24 /test | |
parent | f1fc05b45cd2b0017e36d7905f353ecb7291d44d (diff) |
test: check codes of thrown errors
PR-URL: https://github.com/nodejs/node/pull/23519
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Diffstat (limited to 'test')
-rw-r--r-- | test/parallel/test-buffer-alloc.js | 16 | ||||
-rw-r--r-- | test/parallel/test-buffer-arraybuffer.js | 7 |
2 files changed, 16 insertions, 7 deletions
diff --git a/test/parallel/test-buffer-alloc.js b/test/parallel/test-buffer-alloc.js index 6afcbf1b03b..feca4488119 100644 --- a/test/parallel/test-buffer-alloc.js +++ b/test/parallel/test-buffer-alloc.js @@ -967,12 +967,16 @@ common.expectsError( message: 'argument must be a buffer' }); -const regErrorMsg = - new RegExp('The first argument must be one of type string, Buffer, ' + - 'ArrayBuffer, Array, or Array-like Object\\.'); - -assert.throws(() => Buffer.from(), regErrorMsg); -assert.throws(() => Buffer.from(null), regErrorMsg); +assert.throws(() => Buffer.from(), { + name: 'TypeError [ERR_INVALID_ARG_TYPE]', + message: 'The first argument must be one of type string, Buffer, ' + + 'ArrayBuffer, Array, or Array-like Object. Received type undefined' +}); +assert.throws(() => Buffer.from(null), { + name: 'TypeError [ERR_INVALID_ARG_TYPE]', + message: 'The first argument must be one of type string, Buffer, ' + + 'ArrayBuffer, Array, or Array-like Object. Received type object' +}); // Test prototype getters don't throw assert.strictEqual(Buffer.prototype.parent, undefined); diff --git a/test/parallel/test-buffer-arraybuffer.js b/test/parallel/test-buffer-arraybuffer.js index 8d26f983f2b..2a1ce141079 100644 --- a/test/parallel/test-buffer-arraybuffer.js +++ b/test/parallel/test-buffer-arraybuffer.js @@ -40,7 +40,12 @@ assert.throws(function() { Object.setPrototypeOf(AB, ArrayBuffer); Object.setPrototypeOf(AB.prototype, ArrayBuffer.prototype); Buffer.from(new AB()); -}, TypeError); +}, { + code: 'ERR_INVALID_ARG_TYPE', + name: 'TypeError [ERR_INVALID_ARG_TYPE]', + message: 'The first argument must be one of type string, Buffer,' + + ' ArrayBuffer, Array, or Array-like Object. Received type object' +}); // Test the byteOffset and length arguments { |