Welcome to mirror list, hosted at ThFree Co, Russian Federation.

github.com/nodejs/node.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
path: root/test
diff options
context:
space:
mode:
authorTyler Vann-Campbell <tyler@buddy.com>2018-10-19 10:39:20 +0300
committerMyles Borins <mylesborins@google.com>2018-11-29 19:39:10 +0300
commitce6ddc404dc91a177d400804c1462a2e746ac221 (patch)
treecadee7adf0712b8544cfa3e54256b68180b0be55 /test
parent913c4910c7fd0c386e9d976ed0b6da6a91ecb6b7 (diff)
test: increase coverage of internal/stream/end-of-stream
This change adds test cases to call the function returned by end-of-stream and asserts that callbacks are not called when the stream is ended, or prematurely closed. PR-URL: https://github.com/nodejs/node/pull/23751 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'test')
-rw-r--r--test/parallel/test-stream-finished.js22
1 files changed, 22 insertions, 0 deletions
diff --git a/test/parallel/test-stream-finished.js b/test/parallel/test-stream-finished.js
index 3aade5610c7..86564e824cd 100644
--- a/test/parallel/test-stream-finished.js
+++ b/test/parallel/test-stream-finished.js
@@ -119,3 +119,25 @@ const { promisify } = require('util');
rs.push(null);
rs.resume();
}
+
+// Test that calling returned function removes listeners
+{
+ const ws = new Writable({
+ write(data, env, cb) {
+ cb();
+ }
+ });
+ const removeListener = finished(ws, common.mustNotCall());
+ removeListener();
+ ws.end();
+}
+
+{
+ const rs = new Readable();
+ const removeListeners = finished(rs, common.mustNotCall());
+ removeListeners();
+
+ rs.emit('close');
+ rs.push(null);
+ rs.resume();
+}