diff options
| author | Rich Trott <rtrott@gmail.com> | 2017-10-21 21:10:42 +0300 |
|---|---|---|
| committer | Myles Borins <mylesborins@google.com> | 2017-10-24 00:23:01 +0300 |
| commit | b1c7889ad7b5c541ef227b80258f6081d176bc58 (patch) | |
| tree | a45b0dbeac08129cc801194ca5b755d4f1db7c37 /test | |
| parent | 598787d85446706fe437c874dabf242d2af0fe2f (diff) | |
test: fix common.PIPE path bug
`common.PIPE` is returning a path name in `test` rather than in the
`tmp` directory for each test. This is causing multiple test failures in
CI. Make the path name inside the temporary directories again. This way
the pipe is removed by `common.refreshTmpDir()` on POSIX.
The bug in `common.PIPE` was introduced in
c34ae48083b44f1da7be75c8d11abc9f3aa7ab19.
PR-URL: https://github.com/nodejs/node/pull/16364
Fixes: https://github.com/nodejs/node/issues/16290
Fixes: https://github.com/nodejs/node/issues/16323
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Diffstat (limited to 'test')
| -rw-r--r-- | test/common/index.js | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/test/common/index.js b/test/common/index.js index a138b4d3da0..9a9352bbb2f 100644 --- a/test/common/index.js +++ b/test/common/index.js @@ -274,7 +274,7 @@ Object.defineProperty(exports, 'hasFipsCrypto', { const localRelative = path.relative(process.cwd(), `${exports.tmpDir}/`); const pipePrefix = exports.isWindows ? '\\\\.\\pipe\\' : localRelative; const pipeName = `node-test.${process.pid}.sock`; - exports.PIPE = pipePrefix + pipeName; + exports.PIPE = path.join(pipePrefix, pipeName); } { |