diff options
| author | Richard Lau <rlau@redhat.com> | 2020-12-21 20:44:23 +0300 |
|---|---|---|
| committer | Michaël Zasso <targos@protonmail.com> | 2021-05-01 10:44:46 +0300 |
| commit | 5ac21bceba432bf85aebeae1416794514a66ed63 (patch) | |
| tree | 8e56e28afee99860141376914ef230ab12e8f659 /tools | |
| parent | b57785d89bc548c4048118606919d66dff1c7eb7 (diff) | |
tools: fix make-v8.sh
V8's `tools/dev/v8gen.py` does not like being passed an empty string
(`""`).
PR-URL: https://github.com/nodejs/node/pull/36594
Refs: https://github.com/nodejs/node/pull/36099
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Diffstat (limited to 'tools')
| -rwxr-xr-x | tools/make-v8.sh | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/tools/make-v8.sh b/tools/make-v8.sh index 6b09b515c3d..5a23432b589 100755 --- a/tools/make-v8.sh +++ b/tools/make-v8.sh @@ -36,6 +36,7 @@ if [ "$ARCH" = "s390x" ] || [ "$ARCH" = "ppc64le" ]; then gn gen -v "out.gn/$BUILD_ARCH_TYPE" --args="is_component_build=false is_debug=false use_goma=false goma_dir=\"None\" use_custom_libcxx=false v8_target_cpu=\"$TARGET_ARCH\" target_cpu=\"$TARGET_ARCH\" v8_enable_backtrace=true" ninja -v -C "out.gn/$BUILD_ARCH_TYPE" d8 cctest inspector-test else - PATH=~/_depot_tools:$PATH tools/dev/v8gen.py "$BUILD_ARCH_TYPE" --no-goma "$V8_BUILD_OPTIONS" + # shellcheck disable=SC2086 + PATH=~/_depot_tools:$PATH tools/dev/v8gen.py "$BUILD_ARCH_TYPE" --no-goma $V8_BUILD_OPTIONS PATH=~/_depot_tools:$PATH ninja -C "out.gn/$BUILD_ARCH_TYPE/" d8 cctest inspector-test fi |