diff options
| author | Alexey Kozyatinskiy <kozyatinskiy@chromium.org> | 2018-08-29 19:31:25 +0300 |
|---|---|---|
| committer | Anna Henningsen <anna@addaleax.net> | 2018-08-31 19:57:55 +0300 |
| commit | 4b47d2907ddcd3240f98a6c2db82815a864a346c (patch) | |
| tree | 799246311ddea5dc84d9bd0347cad2945cd875d5 /tools | |
| parent | 21e8ce2297b1dfbc20ff40c7d9acfb0cab22dbb5 (diff) | |
build: do not copy v8-inspector* headers ar part of install
These headers are exposed from V8 for embedder and should not be
used by native addons.
Fixes https://github.com/nodejs/node/issues/22415
PR-URL: https://github.com/nodejs/node/pull/22586
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Diffstat (limited to 'tools')
| -rwxr-xr-x | tools/install.py | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/tools/install.py b/tools/install.py index ce9ceeee1dd..9e192a1cd6e 100755 --- a/tools/install.py +++ b/tools/install.py @@ -157,6 +157,14 @@ def files(action): headers(action) def headers(action): + def ignore_inspector_headers(files, dest): + inspector_headers = [ + 'deps/v8/include/v8-inspector.h', + 'deps/v8/include/v8-inspector-protocol.h' + ] + files = filter(lambda name: name not in inspector_headers, files) + action(files, dest) + action([ 'common.gypi', 'config.gypi', @@ -172,7 +180,7 @@ def headers(action): if sys.platform.startswith('aix'): action(['out/Release/node.exp'], 'include/node/') - subdir_files('deps/v8/include', 'include/node/', action) + subdir_files('deps/v8/include', 'include/node/', ignore_inspector_headers) if 'false' == variables.get('node_shared_libuv'): subdir_files('deps/uv/include', 'include/node/', action) |