diff options
| author | Joyee Cheung <joyeec9h3@gmail.com> | 2022-03-15 12:30:12 +0300 |
|---|---|---|
| committer | Joyee Cheung <joyeec9h3@gmail.com> | 2022-03-23 15:20:14 +0300 |
| commit | bfb4ca8e94b2fda66c8adf048b9ac36c3c432e7f (patch) | |
| tree | be8afac219fd3ce01363a3369fa93166b658bb4e /tools | |
| parent | c37fdacb348fa8f735f0c01fdfb0eefe6152dd34 (diff) | |
bootstrap: use SnapshotData to pass snapshot data around
Instead of passing the snapshot blob, the per-isolate data
indices and the EnvSerializeInfo separately, use the aggregate
type Snapshot to carry these around, and refactor
NodeMainInstance so that it owns the v8::Isolate::CreateParams
when it owns its isolate. This also gets rid of the owns_isolate_
and deserialize_mode_ booleans in NodeMainInstance since
NodeMainInstance can compute these by just checking if it has
pointers to the CreateParams or the SnapshotData.
PR-URL: https://github.com/nodejs/node/pull/42360
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/snapshot/README.md | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/tools/snapshot/README.md b/tools/snapshot/README.md index fb22c03ed50..5792ede4499 100644 --- a/tools/snapshot/README.md +++ b/tools/snapshot/README.md @@ -22,8 +22,7 @@ In the default build of the Node.js executable, to embed a V8 startup snapshot into the Node.js executable, `libnode` is first built with these unresolved symbols: -- `node::NodeMainInstance::GetEmbeddedSnapshotBlob` -- `node::NodeMainInstance::GetIsolateDataIndices` +- `node::NodeMainInstance::GetEmbeddedSnapshotData` Then the `node_mksnapshot` executable is built with C++ files in this directory, as well as `src/node_snapshot_stub.cc` which defines the unresolved |