diff options
| author | Brian Ingenito <28159742+bingenito@users.noreply.github.com> | 2020-11-07 00:18:36 +0300 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2020-11-13 19:37:40 +0300 |
| commit | 4b0308ad34005dfde83afe7e32eb39cdaca9a4a1 (patch) | |
| tree | d836875bf1d1d3e592592865a4c021815a930da0 /vcbuild.bat | |
| parent | e4507e545240809bd78031df5e965a5362f7987e (diff) | |
build: conditionally clear vcinstalldir
For scenario where target env is explicitly specified as vs2019, do
not clear VCINSTALLDIR which was being cleared to handle fallback to
vs2017 block when attempting to find a matching available VS.
Fixes: https://github.com/nodejs/node/issues/35856
PR-URL: https://github.com/nodejs/node/pull/36009
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Diffstat (limited to 'vcbuild.bat')
| -rw-r--r-- | vcbuild.bat | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/vcbuild.bat b/vcbuild.bat index 86a986b3dec..179da60d264 100644 --- a/vcbuild.bat +++ b/vcbuild.bat @@ -249,7 +249,7 @@ echo Looking for Visual Studio 2019 @rem VCINSTALLDIR may be set if run from a VS Command Prompt and needs to be @rem cleared first as vswhere_usability_wrapper.cmd doesn't when it fails to @rem detect the version searched for -set "VCINSTALLDIR=" +if not defined target_env set "VCINSTALLDIR=" call tools\msvs\vswhere_usability_wrapper.cmd "[16.0,17.0)" if "_%VCINSTALLDIR%_" == "__" goto msbuild-not-found set "WIXSDKDIR=%WIX%\SDK\VS2017" |