diff options
Diffstat (limited to '.github/PULL_REQUEST_TEMPLATE.md')
| -rw-r--r-- | .github/PULL_REQUEST_TEMPLATE.md | 14 |
1 files changed, 5 insertions, 9 deletions
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 364754444ac..cce9351dc1e 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,20 +1,18 @@ <!-- -Thank you for submitting a pull request to Node.js. Before you submit, please -review below requirements and walk through the checklist. You can 'tick' -a box by using the letter "x": [x]. +Thank you for your pull request. Please review below requirements and walk +through the checklist. You can 'tick' a box by using the letter "x": [x]. -Run the test suite by invoking: `make -j4 lint test` on linux or -`vcbuild test nosign` on Windows. +Run the test suite with: `make -j4 test` on UNIX or `vcbuild test nosign` on +Windows. If this aims to fix a regression or you’re adding a feature, make sure you also -write a test. Finally – if possible – a benchmark that quantifies your changes. +write a test. If possible, include a benchmark that quantifies your changes. Finally, read through our contributors guide and make adjustments as necessary: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md --> ##### Checklist - <!-- remove lines that do not apply to you --> - [ ] tests and code linting passes @@ -24,10 +22,8 @@ https://github.com/nodejs/node/blob/master/CONTRIBUTING.md ##### Affected core subsystem(s) - <!-- provide affected core subsystem(s) (like doc, cluster, crypto, etc) --> ##### Description of change - <!-- provide a description of the change below this comment --> |