Welcome to mirror list, hosted at ThFree Co, Russian Federation.

github.com/nodejs/node.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-09-25tools: update lint-md-dependencies to rollup@2.79.1actions/tools-update-lint-md-dependenciesNode.js GitHub Bot
2022-09-25src: restore IS_RELEASE to 0Bryan English
PR-URL: https://github.com/nodejs/node/pull/44758 Reviewed-By: Ruy Adorno <ruyadorno@google.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2022-09-24doc: update the deprecation for exit code to clarify its scopeDaeyeon Jeong
This updates the deprecation, DEP0164, to clarify its scope. Previously, `process.exitCode` wasn't mentioned but it needs to be applied with the same deprecation because its meaning is the same as the `code` value and it's overridden with the `code` value in `process.exit()`. Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com> Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: https://github.com/nodejs/node/pull/44714 Refs: https://github.com/nodejs/node/pull/44712 Refs: https://github.com/nodejs/node/pull/43738 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2022-09-232022-09-23, Version 18.9.1 (Current)RafaelGSS
This is a security release. Notable changes: * crypto: fix weak randomness in WebCrypto keygen (Ben Noordhuis) https://github.com/nodejs-private/node-private/pull/346 * deps: MacOS - fix location of OpenSSL config file (Michael Dawson) https://github.com/nodejs-private/node-private/pull/345 * http: disable chunked encoding when OBS fold is used (Paolo Insogna) https://github.com/nodejs-private/node-private/pull/341 * src: fix IPv4 non routable validation (RafaelGSS) https://github.com/nodejs-private/node-private/pull/337 PR-URL: https://github.com/nodejs-private/node-private/pull/350
2022-09-232022-09-23, Version 16.17.1 'Gallium' (LTS)Ruy Adorno
This is a security release. Notable changes: crypto: * fix weak randomness in WebCrypto keygen (Ben Noordhuis) https://github.com/nodejs-private/node-private/pull/346 http: * disable chunked encoding when using OBS fold is used (Paolo Insogna) https://github.com/nodejs-private/node-private/pull/341 src: * fix IPv4 non routable validation (RafaelGSS) https://github.com/nodejs-private/node-private/pull/337 PR-URL: https://github.com/nodejs-private/node-private/pull/352
2022-09-232022-09-23, Version 14.20.1 'Fermium' (LTS)Bryan English
This is a security release. Notable changes: The following CVEs are fixed in this release: * CVE-2022-32212: DNS rebinding in --inspect on macOS (High) * CVE-2022-32213: bypass via obs-fold mechanic (Medium) * CVE-2022-35256: HTTP Request Smuggling Due to Incorrect Parsing of Header Fields (Medium) PR-URL: https://github.com/nodejs-private/node-private/pull/348
2022-09-23http: disable chunked encoding when OBS fold is usedPaolo Insogna
Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> PR-URL: #341 CVE-ID: CVE-2022-32213, CVE-2022-32215, CVE-2022-35256
2022-09-23crypto: fix weak randomness in WebCrypto keygenBen Noordhuis
Commit dae283d96f from August 2020 introduced a call to EntropySource() in SecretKeyGenTraits::DoKeyGen() in src/crypto/crypto_keygen.cc. There are two problems with that: 1. It does not check the return value, it assumes EntropySource() always succeeds, but it can (and sometimes will) fail. 2. The random data returned byEntropySource() may not be cryptographically strong and therefore not suitable as keying material. An example is a freshly booted system or a system without /dev/random or getrandom(2). EntropySource() calls out to openssl's RAND_poll() and RAND_bytes() in a best-effort attempt to obtain random data. OpenSSL has a built-in CSPRNG but that can fail to initialize, in which case it's possible either: 1. No random data gets written to the output buffer, i.e., the output is unmodified, or 2. Weak random data is written. It's theoretically possible for the output to be fully predictable because the CSPRNG starts from a predictable state. Replace EntropySource() and CheckEntropy() with new function CSPRNG() that enforces checking of the return value. Abort on startup when the entropy pool fails to initialize because that makes it too easy to compromise the security of the process. Refs: https://hackerone.com/bugs?report_id=1690000 Refs: https://github.com/nodejs/node/pull/35093
2022-09-23deps: MacOS - fix location of OpenSSL config fileMichael Dawson
- Restore the location were the OpenSSL config file is loaded by default on MacOS back to where it was on earlier versions - Remove warnings about OPENSSLDIR being multiply defined Signed-off-by: Michael Dawson <mdawson@devrus.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> PR-URL: https://github.com/nodejs-private/node-private/pull/345 CVE-ID: CVE-2022-32222
2022-09-23src: fix IPv4 non routable validationRafaelGSS
Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> PR-URL: https://github.com/nodejs-private/node-private/pull/337 CVE-ID: CVE-2022-32212, CVE-2018-7160
2022-09-23doc: update guidance for adding new modulesMichael Dawson
- updated based on decision to use node: prefix in https://github.com/nodejs/TSC/pull/1206 - updated based on agreement in TSC meeting on adding /promises to existing modules as per minutes - https://github.com/nodejs/TSC/pull/1281 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: https://github.com/nodejs/node/pull/44576 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
2022-09-23test: change promise to async/await in debugger-watcher“Pooja
PR-URL: https://github.com/nodejs/node/pull/44687 Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
2022-09-23stream: handle a pending pull request from a released readerDaeyeon Jeong
In order to meet the specification, this includes mainly the followings: - Adding the 'release steps' to ReadableStreamController - Responding to a pull request from a released reader in ReadableByteStreamController Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com PR-URL: https://github.com/nodejs/node/pull/44702 Refs: https://streams.spec.whatwg.org/#abstract-opdef-readablebytestreamcontroller-releasesteps Refs: https://streams.spec.whatwg.org/#readable-byte-stream-controller-respond-in-readable-state Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
2022-09-23doc: add registry number for Electron 22Keeley Hammond
PR-URL: https://github.com/nodejs/node/pull/44748 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
2022-09-23test: fix addon tests compilation with OpenSSL 1.1.1Adam Majer
openssl/provider.h header is not part of OpenSSL 1.1.1 so do not include it when building with an older instance. Fixes: https://github.com/nodejs/node/issues/44722 PR-URL: https://github.com/nodejs/node/pull/44725 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
2022-09-22util: increase robustness with primordialsJordan Harband
PR-URL: https://github.com/nodejs/node/pull/41212 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
2022-09-22doc,crypto: cleanup removed pbkdf2 behavioursFilip Skokan
PR-URL: https://github.com/nodejs/node/pull/44733 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
2022-09-22benchmark: fix startup benchmarkEvan Lucas
This allows the misc/startup benchmark to run again after the renaming of the C++ `native_module` to `builtins` PR-URL: https://github.com/nodejs/node/pull/44727 Refs: https://github.com/nodejs/node/pull/44135 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
2022-09-22doc: include code examples for webstreams consumersLucas Santos
Add missing examples for webstreams consumers Doc URL: https://nodejs.org/api/webstreams.html#streamconsumerstextstream PR-URL: https://github.com/nodejs/node/pull/44387 Reviewed-By: Erick Wendel <erick.workspace@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
2022-09-21src: avoid using v8 on Isolate terminationSantiago Gimeno
Fix multiple instances of those uncovered while running the tests on debug builds. Fixes: https://github.com/nodejs/node-v8/issues/227 PR-URL: https://github.com/nodejs/node/pull/44669 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
2022-09-21doc,crypto: update webcrypto docs for global accessFilip Skokan
PR-URL: https://github.com/nodejs/node/pull/44723 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2022-09-21gyp: libnode for ios app embeddingchexiongsheng
PR-URL: https://github.com/nodejs/node/pull/44210 Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
2022-09-20doc: mention where to push security commitsRafaelGSS
PR-URL: https://github.com/nodejs/node/pull/44691 Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
2022-09-20doc: remove extra space on threadpool usageConnor Burton
PR-URL: https://github.com/nodejs/node/pull/44734 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2022-09-20node-api: add deprecation code of uncaught exceptionChengzhong Wu
Deprecation should reference a valid deprecation code. PR-URL: https://github.com/nodejs/node/pull/44624 Refs: https://github.com/nodejs/node/pull/36510 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michael Dawson <midawson@redhat.com>
2022-09-20test: deflake watch mode testsMoshe Atlow
PR-URL: https://github.com/nodejs/node/pull/44621 Fixes: https://github.com/nodejs/node/issues/44655 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
2022-09-19esm,loader: tidy ESMLoader internalsJacob Smith
PR-URL: https://github.com/nodejs/node/pull/44701 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2022-09-19meta: add mailmap entry for dnlupRich Trott
This updates dnlup's name to their preferred email per their last pull request. This will also prevent duplicate entries for dnlup when the update-authors job runs. It also moves one unrelated line in .mailmap so that all lines are sorted in lexical order. PR-URL: https://github.com/nodejs/node/pull/44716 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
2022-09-19tools: add update-llhttp.shPaolo Insogna
PR-URL: https://github.com/nodejs/node/pull/44652 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> Co-authored-by: Tobias Nießen <tniessen@tnie.de> Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
2022-09-18meta: update AUTHORSNode.js GitHub Bot
PR-URL: https://github.com/nodejs/node/pull/44705 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
2022-09-18src: remove <unistd.h> from node_os.ccTobias Nießen
The file does not use sysconf() and its use of gethostname() has been removed, so including <unistd.h> appears to be unnecessary. PR-URL: https://github.com/nodejs/node/pull/44668 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2022-09-18deps: update to ngtcp2 0.8.1 and nghttp3 0.7.0Tobias Nießen
Refs: https://github.com/nodejs/node/pull/44619 Co-authored-by: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/44622 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2022-09-18module: open stat/readPackage to mutationsMaël Nison
PR-URL: https://github.com/nodejs/node/pull/44537 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2022-09-18deps: update corepack to 0.14.1Node.js GitHub Bot
PR-URL: https://github.com/nodejs/node/pull/44704 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2022-09-18deps: update ngtcp2 update instructionsTobias Nießen
Prefer tagged versions over the latest commit on the development branch, and a few other minor improvements. PR-URL: https://github.com/nodejs/node/pull/44619 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2022-09-18http: throw error on content-length mismatchsidwebworks
PR-URL: https://github.com/nodejs/node/pull/44378 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>
2022-09-18meta: move dnlup to emeritidnlup
PR-URL: https://github.com/nodejs/node/pull/44667 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
2022-09-17doc: make legacy banner slightly less brightRich Trott
PR-URL: https://github.com/nodejs/node/pull/44665 Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
2022-09-17deps: upgrade npm to 8.19.2npm CLI robot
PR-URL: https://github.com/nodejs/node/pull/44632 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
2022-09-17crypto: remove non-standard `webcrypto.Crypto.prototype.CryptoKey`Antoine du Hamel
`CryptoKey` is already available on the global object. PR-URL: https://github.com/nodejs/node/pull/42083 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
2022-09-17lib: enable global WebCrypto by defaultAntoine du Hamel
Enables `--experimental-global-webcrypto` by default, and ensures that the classic `node:crypto` core module is still available in `--eval` or `--print` contexts. PR-URL: https://github.com/nodejs/node/pull/42083 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
2022-09-17dns: remove unnecessary parameter from validateOneOfYagiz Nizipli
PR-URL: https://github.com/nodejs/node/pull/44635 Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
2022-09-17doc: improve building doc for Windows PowershellBrian Muenzenmeyer
PR-URL: https://github.com/nodejs/node/pull/44625 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
2022-09-17doc: maintain only one list of MODP groupsTobias Nießen
There are two lists of MODP groups, one of which is redundant and does not mark weak groups as deprecated. Remove said list and refer readers to the first list instead. Refs: https://github.com/nodejs/node/pull/43986 Refs: https://github.com/nodejs/node/pull/44588 PR-URL: https://github.com/nodejs/node/pull/44644 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2022-09-16test: fix test-performance-measuresmitley
Refs: https://github.com/nodejs/node/issues/42949 Looking at the documentation for setTimeout (https://nodejs.org/api/timers.html#settimeoutcallback-delay-args) there is no guarantee that setTimeout won't complete early. From the failure of https://github.com/nodejs/node/issues/42949 this is likely what happened. I have updated the assert.ok test to allow some variation in the test. PR-URL: https://github.com/nodejs/node/pull/44637 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
2022-09-16doc: add legendecas to TSC listMichael Dawson
Refs: https://github.com/nodejs/TSC/issues/1282 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: https://github.com/nodejs/node/pull/44662 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2022-09-16tools: fix typo in update-nghttp2.shLuigi Pinca
PR-URL: https://github.com/nodejs/node/pull/44664 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
2022-09-16tools: add timezone update workflowLenvin Gonsalves
Fixes: https://github.com/nodejs/node/issues/43134 PR-URL: https://github.com/nodejs/node/pull/43988 Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
2022-09-16test: improve lib/readline.js coverageMURAKAMI Masahiko
PR-URL: https://github.com/nodejs/node/pull/42686 Refs: https://coverage.nodejs.org/coverage-a0461255c05c79cf/lib/readline.js.html#L105 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
2022-09-15doc,inspector: document changes of inspector.closelegendecas
Retrospectively document the changes history of the `inspector.close` API. PR-URL: https://github.com/nodejs/node/pull/44628 Refs: https://github.com/nodejs/node/pull/44489 Refs: https://github.com/nodejs/node/pull/13228 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>