Welcome to mirror list, hosted at ThFree Co, Russian Federation.

github.com/nodejs/node.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
path: root/Makefile
AgeCommit message (Collapse)Author
2022-05-23build: run V8 tests with detected Python versionRichard Lau
V8's test runner now requires Python 3. Use the Python binary we detected that is used elsewhere in the Makefile. PR-URL: https://github.com/nodejs/node/pull/42740 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
2022-02-26build: add corepack to the auto-updated dependenciesMaël Nison
PR-URL: https://github.com/nodejs/node/pull/42090 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com>
2022-01-18doc: make contributing info more discoverableMichael Dawson
There are been several discussions in recent PRs about the docs related to contributing not being very discoverable. Move these docs from doc/guides/ to doc/contributing. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: https://github.com/nodejs/node/pull/41408 Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: James M Snell <jasnell@gmail.com>
2022-01-18tools: add missing `.PHONY` and `.NOTPARALLEL` targets in `Makefile`Antoine du Hamel
PR-URL: https://github.com/nodejs/node/pull/41515 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yash Ladha <yash@yashladha.in>
2022-01-18build: fix npm version detectionMichaël Zasso
Npm's package.json now contains two fields named "version". Grep for the top-level one. Fixes: https://github.com/nodejs/build/issues/2850 PR-URL: https://github.com/nodejs/node/pull/41575 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
2022-01-06build: start build on z/OSalexcfyung
Update configure.py, Makefile, and common.gypi to get the build started on z/OS. Co-authored-by: Gaby Baghdadi <baghdadi@ca.ibm.com> Co-authored-by: Wayne Zhang <zsw007@gmail.com> PR-URL: https://github.com/nodejs/node/pull/41273 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
2021-12-07build: skip documentation generation if no ICURich Trott
Closes: https://github.com/nodejs/node/issues/41077 PR-URL: https://github.com/nodejs/node/pull/41091 Fixes: https://github.com/nodejs/node/issues/41077 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2021-12-05tools: use jsdoc recommended rulesRich Trott
Enable all recommended JSDoc linting rules and disable the ones we don't (yet?) meet. They can be enabled one by one by removing the lines that turn them off. This requires adding --max-warnings to the ESLint invocations in Makefile and vcbuild.bat because the preset enables the recommended rules as warnings and not errors. PR-URL: https://github.com/nodejs/node/pull/41057 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
2021-11-27build: remove legacy -J test.py option from Makefile/vcbuildRich Trott
PR-URL: https://github.com/nodejs/node/pull/40945 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
2021-10-30test: test `crypto.setEngine()` using an actual engineDarshan Sen
Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: https://github.com/nodejs/node/pull/40481 Reviewed-By: James M Snell <jasnell@gmail.com>
2021-10-11deps,test,src,doc,tools: update to OpenSSL 3.0Daniel Bevenius
This pull request updates the OpenSSL version that is statically linked with Node.js from OpenSSl 1.1.1 to quictls OpenSSL 3.0.0+quic. This pull request will replace the OpenSSL version that is currently in the deps directory and when performing a normal build OpenSSL 3.0+quic will be statically linked to the Node.js executable. We will still be able to dynamically link to OpenSSL 1.1.1 and we have a CI job which dynamically links to OpenSSL 1.1.1 which is run for every pull request to make sure that we maintain backward compatibility. PR-URL: https://github.com/nodejs/node/pull/38512 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
2021-09-29build: set DESTCPU correctly for 'make binary' on Apple SiliconChris Heisterkamp
PR-URL: https://github.com/nodejs/node/pull/40147 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
2021-09-25tools: implement markdown formattingRich Trott
Markdown formatter is now available via `mark format-md` (or `vcbuild format-md` on Windows). PR-URL: https://github.com/nodejs/node/pull/40181 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
2021-09-25tools: re-implement lint-md without unified-argsRich Trott
`unified-args` ignores settings in the preset, expecting them to be in remarkrc files or passed on the command line instead. Realizing that we always send the same configuration options via the command-line anyway, this removes `unified-args`. This means the preset settings are now respected and it removes nearly 30000 lines of code in the resulting rollup file. I wasn't sure I was going to want to keep rollup so I started re-implementing this without it, but ended up putting a minimal rollup back as it still saves about 90000 lines of code vs. checking in `node_modules`. PR-URL: https://github.com/nodejs/node/pull/40180 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
2021-09-23build: add --no-user for pip commands in MakefileRich Trott
I ran into "Cannot combine --user and --target" in an environment and adding --no-user seemed to fix it. Refs: https://stackoverflow.com/a/67259534/436641 PR-URL: https://github.com/nodejs/node/pull/40169 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Christian Clauss <cclauss@me.com>
2021-09-07build: add YAML lintingRich Trott
PR-URL: https://github.com/nodejs/node/pull/40007 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
2021-08-25deps: add corepackMaël Nison
Corepack provides shims for Yarn and pnpm in order to soften the developer experience when working on Node projects. Refs: https://github.com/nodejs/node/issues/15244 Refs: https://github.com/nodejs/TSC/issues/904 PR-URL: https://github.com/nodejs/node/pull/39608 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2021-08-22tools: fix markdown lintingRich Trott
This updates remark-preset-lint-node to 3.0.1, which actually works unlike the 3.0.0 version we're using. (Sorry about 3.0.0 not actually linting!) It also updates rollup and the rollup config. So this uses the latest everything as of this writing. PR-URL: https://github.com/nodejs/node/pull/39832 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2021-07-29build: override python executable path on configurelegendecas
PR-URL: https://github.com/nodejs/node/pull/39465 Fixes: https://github.com/nodejs/node/issues/39408 Fixes: https://github.com/nodejs/node/issues/39456 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
2021-07-23doc,tools: remove `checkLinks.mjs`Antoine du Hamel
The checks made by this are now integrated to `remark-preset-lint-node`, there are no reason to keep it around anymore. PR-URL: https://github.com/nodejs/node/pull/39206 Reviewed-By: Rich Trott <rtrott@gmail.com>
2021-07-19build: update coverage Makefile target commentsRichard Lau
Update the comments for the `coverage` Makefile target. - Source files under `lib` are no longer instrumented since https://github.com/nodejs/node/commit/d1dee495db1451e74f5364c8687148a53ff0b50d - Fix the name of the related CI job. PR-URL: https://github.com/nodejs/node/pull/39365 Refs: https://github.com/nodejs/node/pull/25157 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
2021-07-12build: update gcovr for gcc 8 compatibilityRichard Lau
Update the version of `gcovr` used for C++ coverage from 3.4 to 4.2 for compatibility with gcc/g++ 8. PR-URL: https://github.com/nodejs/node/pull/39326 Refs: https://github.com/nodejs/node/issues/39303 Refs: https://github.com/gcovr/gcovr/pull/228 Refs: https://github.com/nodejs/build/pull/2705 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
2021-07-11build: remove unused comment in MakefileLitoMore
PR-URL: https://github.com/nodejs/node/pull/39171 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
2021-07-11build: allow to build riscv64 using MakefileMakoto Kato
PR-URL: https://github.com/nodejs/node/pull/39048 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
2021-07-05node-api: cctest on v8impl::Referencelegendecas
PR-URL: https://github.com/nodejs/node/pull/38970 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com>
2021-06-23build: don't pass `--mode` argument to V8 test-runnerRichard Lau
V8's test-runner dropped the `--mode` argument some time back, and now produces the following error if run with it: run-tests.py: error: no such option: --mode PR-URL: https://github.com/nodejs/node/pull/39055 Refs: https://github.com/nodejs/node/pull/35705 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2021-06-14tools: update doctool dependencies, migrate to ESMMichaël Zasso
- Migrated to ESM because some dependencies now require it. - Did not update `highlight.js` to v11 because it has many breaking changes. - Used non-deprecated `highlight.js` API. Refs: https://github.com/highlightjs/highlight.js/issues/2277 Fixes: https://github.com/nodejs/node/issues/38938 Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: https://github.com/nodejs/node/pull/38966 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2021-06-11build: make build-addons errors fail the buildRichard Lau
The `build-addons` makefile target runs `tools/doc/addon-verify.js` and then uses `touch` to update a timestamp file. Unconditionally calling `touch` was losing the exit code from `tools/doc/addon-verify.js` so any errors produced by that script were not failing the build. PR-URL: https://github.com/nodejs/node/pull/38983 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
2021-06-09build: don't pass python override to V8 buildRichard Lau
If the `configure.py` script is executed by a Python binary that is not the one on the PATH it will create a `python` symlink in `out/tools/bin` and prefix that to the PATH so it is used instead of the one that otherwise would have been found on the PATH. This is done so that gyp scripts shelling out to `python` execute with the same version of Python as used to run the configure script. V8's build uses V8's build toolchain (i.e. not gyp) and currently that is incompatible with Python 3. Prevent prefixing the PATH for the V8 build so that it picks up `python` from the unprefixed PATH. This will allow us to build Node.js with Python 3 but still use Python 2 to build V8 in the CI. PR-URL: https://github.com/nodejs/node/pull/38969 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
2021-05-22build: replace non-POSIX test -a|oIssam E. Maghni
test/[ from sbase unix tools[1] throws "too many arguments" if -a or -o is provided. The syntax has been marked obsolescent as per the manual[2]. [1] http://core.suckless.org/sbase/ [2] https://pubs.opengroup.org/onlinepubs/9699919799/utilities/test.html#tag_20_128_16 PR-URL: https://github.com/nodejs/node/pull/38731 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
2021-04-25test,debugger: migrate node-inspect tests to coreRich Trott
Migrate the node-inspect tests to core (where node-inspect code now lives) and remove node-inspect from deps directory. PR-URL: https://github.com/nodejs/node/pull/38161 Refs: https://github.com/nodejs/node/discussions/36481 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
2021-04-15build: default PYTHON to python3 in MakefileMichaël Zasso
So that direct calls to `make` which spawn the configure script do not use Python 2. PR-URL: https://github.com/nodejs/node/pull/37764 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ash Cripps <acripps@redhat.com> Reviewed-By: Richard Lau <rlau@redhat.com>
2021-04-11build: add pummel tests to ci runsRich Trott
PR-URL: https://github.com/nodejs/node/pull/34289 Reviewed-By: Richard Lau <rlau@redhat.com>
2021-04-09build: update Makefile to support fat binaryAsh Cripps
build a binary that is both x86_64 and arm64 on macos PR-URL: https://github.com/nodejs/node/pull/37861 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
2021-04-07build: package release changelog for releasesRichard Lau
Package the changelog for the release line as `CHANGELOG.md` when building a release binary tarball. PR-URL: https://github.com/nodejs/node/pull/38033 Fixes: https://github.com/nodejs/node/issues/38025 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
2021-03-06tools: add support for mjs and cjs JS snippet lintingAntoine du Hamel
Refs: https://github.com/nodejs/node/pull/37162 Refs: https://github.com/nodejs/remark-preset-lint-node/pull/176 PR-URL: https://github.com/nodejs/node/pull/37311 Refs: https://github.com/eslint/eslint-plugin-markdown/pull/172 Reviewed-By: Rich Trott <rtrott@gmail.com>
2021-03-03tools: update eslint-plugin-markdown configurationcjihrig
This commit updates the linting setup to work with eslint-plugin-markdown@2.0.0. This also allows the update-eslint script to continue to function properly without changes. PR-URL: https://github.com/nodejs/node/pull/37549 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
2021-02-22tools: run doctool tests on GitHub Actions CIAntoine du Hamel
PR-URL: https://github.com/nodejs/node/pull/37398 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
2021-01-20tools,doc: list the stability status of each APIZijian Liu
Fixes: https://github.com/nodejs/node/issues/23723 PR-URL: https://github.com/nodejs/node/pull/36223 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2021-01-11build: refactor Makefileraisinten
* add character classes * replace echo -n with printf Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: https://github.com/nodejs/node/pull/36759 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2020-12-15build: fix make test-npmRuy Adorno
Fixes running npm tests with `make test-npm` PR-URL: https://github.com/nodejs/node/pull/36369 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2020-12-05tools: remove bashisms from macOS release scriptsAntoine du Hamel
PR-URL: https://github.com/nodejs/node/pull/36121 Reviewed-By: Rich Trott <rtrott@gmail.com>
2020-11-27build: fix typo in Makefileraisinten
PR-URL: https://github.com/nodejs/node/pull/36176 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
2020-11-19build: replace which with command -vraisinten
PR-URL: https://github.com/nodejs/node/pull/36118 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
2020-11-03build: fix lint-js-fix targetAntoine du Hamel
Refs: https://github.com/nodejs/node/pull/35708 PR-URL: https://github.com/nodejs/node/pull/35927 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
2020-10-30doc: recommend test-doc instead of lint-mdAntoine du Hamel
The documentation style guide used to recommend checking changes in the docs by running `make lint-md`. This leaves out some important checks which are contained in the `test-doc` build target. This commit also replaces `lint` by `lint-md` in the list of `test-doc`'s prerequisites. PR-URL: https://github.com/nodejs/node/pull/35708 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
2020-10-30build,tools: add lint-js-doc targetAntoine du Hamel
Add a build target to lint JS code in Markdown files only. PR-URL: https://github.com/nodejs/node/pull/35708 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
2020-10-25test: refactor coverage logicbcoe
Cleanup logic in Makefile for coverage. Update BUILDING.md accordingly. PR-URL: https://github.com/nodejs/node/pull/35767 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
2020-10-22test: add windows and C++ coverageBenjamin Coe
Collect Windows and C++ coverage. Configure codecov so that comments are more concise and are only left when coverage varies. PR-URL: https://github.com/nodejs/node/pull/35670 Fixes: https://github.com/nodejs/node/issues/35696 Refs: https://github.com/nodejs/node/pull/35653 Refs: https://github.com/nodejs/node/issues/35646 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
2020-10-21build: use make functions instead of echoAntoine du Hamel
PR-URL: https://github.com/nodejs/node/pull/35707 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-04 15:46:21 +0300