From 92dd9b59eb0c2146c7869dfda4b935c1ce663f10 Mon Sep 17 00:00:00 2001 From: Eugene Ostroukhov Date: Tue, 22 May 2018 14:20:24 -0700 Subject: inspector: get rid of the make_unique PR-URL: https://github.com/nodejs/node/pull/20895 Reviewed-By: Anna Henningsen Reviewed-By: Richard Lau Reviewed-By: Anatoli Papirovski Reviewed-By: Tiancheng "Timothy" Gu --- src/inspector/tracing_agent.cc | 6 ++++-- src/inspector_agent.cc | 4 ++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/inspector/tracing_agent.cc b/src/inspector/tracing_agent.cc index 2d98fa1ee52..c0425aab29d 100644 --- a/src/inspector/tracing_agent.cc +++ b/src/inspector/tracing_agent.cc @@ -56,7 +56,7 @@ TracingAgent::~TracingAgent() { } void TracingAgent::Wire(UberDispatcher* dispatcher) { - frontend_ = std::make_unique(dispatcher->channel()); + frontend_.reset(new NodeTracing::Frontend(dispatcher->channel())); NodeTracing::Dispatcher::wire(dispatcher, this); } @@ -77,7 +77,9 @@ DispatchResponse TracingAgent::start( return DispatchResponse::Error("At least one category should be enabled"); trace_writer_ = env_->tracing_agent()->AddClient( - categories_set, std::make_unique(frontend_.get())); + categories_set, + std::unique_ptr( + new InspectorTraceWriter(frontend_.get()))); return DispatchResponse::OK(); } diff --git a/src/inspector_agent.cc b/src/inspector_agent.cc index 50aa23b63cd..162bc6770e5 100644 --- a/src/inspector_agent.cc +++ b/src/inspector_agent.cc @@ -198,8 +198,8 @@ class ChannelImpl final : public v8_inspector::V8Inspector::Channel, std::unique_ptr delegate) : delegate_(std::move(delegate)) { session_ = inspector->connect(1, this, StringView()); - node_dispatcher_ = std::make_unique(this); - tracing_agent_ = std::make_unique(env); + node_dispatcher_.reset(new protocol::UberDispatcher(this)); + tracing_agent_.reset(new protocol::TracingAgent(env)); tracing_agent_->Wire(node_dispatcher_.get()); } -- cgit v1.2.3