From 678e1be6aa145b99397342bb4a00440ba4bf4999 Mon Sep 17 00:00:00 2001
From: Anna Henningsen <anna@addaleax.net>
Date: Sat, 21 Mar 2020 10:08:08 +0100
Subject: src: delete CallbackInfo when cleared from cleanup hook
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Fixes: https://github.com/nodejs/node/issues/32400

PR-URL: https://github.com/nodejs/node/pull/32405
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
---
 src/node_buffer.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'src/node_buffer.cc')

diff --git a/src/node_buffer.cc b/src/node_buffer.cc
index a2e6ec27f82..77120d6af4a 100644
--- a/src/node_buffer.cc
+++ b/src/node_buffer.cc
@@ -163,7 +163,6 @@ void CallbackInfo::WeakCallback(
     const WeakCallbackInfo<CallbackInfo>& data) {
   CallbackInfo* self = data.GetParameter();
   self->WeakCallback(data.GetIsolate());
-  delete self;
 }
 
 
@@ -171,6 +170,7 @@ void CallbackInfo::WeakCallback(Isolate* isolate) {
   callback_(data_, hint_);
   int64_t change_in_bytes = -static_cast<int64_t>(sizeof(*this));
   isolate->AdjustAmountOfExternalAllocatedMemory(change_in_bytes);
+  delete this;
 }
 
 
-- 
cgit v1.2.3