From 8c02f9b7c844909cf5977d065b793c99eb0f9c45 Mon Sep 17 00:00:00 2001 From: Ben Noordhuis Date: Fri, 9 Mar 2012 06:35:50 -0800 Subject: buffer: throw from constructor if length > kMaxLength Throw, don't abort. `new Buffer(0x3fffffff + 1)` used to bring down the process with the following error message: FATAL ERROR: v8::Object::SetIndexedPropertiesToExternalArrayData() length exceeds max acceptable value Fixes #2280. --- src/node_buffer.h | 3 +++ 1 file changed, 3 insertions(+) (limited to 'src/node_buffer.h') diff --git a/src/node_buffer.h b/src/node_buffer.h index ef7cf4fd837..abfafa3264f 100644 --- a/src/node_buffer.h +++ b/src/node_buffer.h @@ -65,6 +65,9 @@ namespace node { class NODE_EXTERN Buffer: public ObjectWrap { public: + // mirrors deps/v8/src/objects.h + static const int kMaxLength = 0x3fffffff; + static v8::Persistent constructor_template; static bool HasInstance(v8::Handle val); -- cgit v1.2.3