From f911e09ab435f5ab8a8e50a6d59aa9a01923058d Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Sat, 25 Aug 2018 01:41:02 +0200 Subject: src: deprecate option variables in public API MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit These variables should never have been exposed as part of the public API, and certainly not as variables. Using CLI options parser is the right thing to do here, at least until we expose some part of the options parser API publicly (which should be possible to do now). PR-URL: https://github.com/nodejs/node/pull/22515 Reviewed-By: Gus Caplan Reviewed-By: Refael Ackermann Reviewed-By: James M Snell Reviewed-By: Trivikram Kamat Reviewed-By: Colin Ihrig Reviewed-By: Joyee Cheung Reviewed-By: Tobias Nießen Reviewed-By: Ruben Bridgewater --- src/node_buffer.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'src/node_buffer.h') diff --git a/src/node_buffer.h b/src/node_buffer.h index e8d306e7dd6..c1e3b859483 100644 --- a/src/node_buffer.h +++ b/src/node_buffer.h @@ -27,8 +27,9 @@ namespace node { -// TODO(addaleax): Deprecate and remove this ASAP. -extern bool zero_fill_all_buffers; +// TODO(addaleax): Remove this. +NODE_DEPRECATED("use command-line flags", + extern bool zero_fill_all_buffers); namespace Buffer { -- cgit v1.2.3