From 43d2e247c7c198fcbbded3e13fa3996687848660 Mon Sep 17 00:00:00 2001
From: Joyee Cheung <joyeec9h3@gmail.com>
Date: Tue, 12 Apr 2022 00:38:57 +0800
Subject: bootstrap: move embedded snapshot to SnapshotBuilder
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

So that the embedded snapshot can be reused by the worker.

PR-URL: https://github.com/nodejs/node/pull/42702
Refs: https://github.com/nodejs/node/issues/35711
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
---
 src/node_external_reference.cc | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

(limited to 'src/node_external_reference.cc')

diff --git a/src/node_external_reference.cc b/src/node_external_reference.cc
index 94198719b6a..9a89977094b 100644
--- a/src/node_external_reference.cc
+++ b/src/node_external_reference.cc
@@ -7,9 +7,11 @@
 namespace node {
 
 const std::vector<intptr_t>& ExternalReferenceRegistry::external_references() {
-  CHECK(!is_finalized_);
-  external_references_.push_back(reinterpret_cast<intptr_t>(nullptr));
-  is_finalized_ = true;
+  if (!is_finalized_) {
+    external_references_.push_back(reinterpret_cast<intptr_t>(nullptr));
+    is_finalized_ = true;
+  }
+
   return external_references_;
 }
 
-- 
cgit v1.2.3