From 110a9cd8db515c4d1a9ac5cd8837291da7c6c5ea Mon Sep 17 00:00:00 2001 From: Ben Noordhuis Date: Wed, 3 Jul 2013 04:23:44 +0200 Subject: lib, src: upgrade after v8 api change This is a big commit that touches just about every file in the src/ directory. The V8 API has changed in significant ways. The most important changes are: * Binding functions take a const v8::FunctionCallbackInfo& argument rather than a const v8::Arguments& argument. * Binding functions return void rather than v8::Handle. The return value is returned with the args.GetReturnValue().Set() family of functions. * v8::Persistent no longer derives from v8::Handle and no longer allows you to directly dereference the object that the persistent handle points to. This means that the common pattern of caching oft-used JS values in a persistent handle no longer quite works, you first need to reconstruct a v8::Local from the persistent handle with the Local::New(isolate, persistent) factory method. A handful of (internal) convenience classes and functions have been added to make dealing with the new API a little easier. The most visible one is node::Cached, which wraps a v8::Persistent with some template sugar. It can hold arbitrary types but so far it's exclusively used for v8::Strings (which was by far the most commonly cached handle type.) --- src/node_stat_watcher.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'src/node_stat_watcher.h') diff --git a/src/node_stat_watcher.h b/src/node_stat_watcher.h index 94ed10a0eea..9fd58206142 100644 --- a/src/node_stat_watcher.h +++ b/src/node_stat_watcher.h @@ -37,9 +37,9 @@ class StatWatcher : ObjectWrap { StatWatcher(); virtual ~StatWatcher(); - static v8::Handle New(const v8::Arguments& args); - static v8::Handle Start(const v8::Arguments& args); - static v8::Handle Stop(const v8::Arguments& args); + static void New(const v8::FunctionCallbackInfo& args); + static void Start(const v8::FunctionCallbackInfo& args); + static void Stop(const v8::FunctionCallbackInfo& args); private: static void Callback(uv_fs_poll_t* handle, -- cgit v1.2.3