From 85404c5c558ebbba3aaf27c56d1edccc2061d664 Mon Sep 17 00:00:00 2001 From: Ryan Dahl Date: Mon, 18 Jul 2011 13:45:11 -0700 Subject: Move HandleWrap rules to one place --- src/pipe_wrap.cc | 21 --------------------- 1 file changed, 21 deletions(-) (limited to 'src/pipe_wrap.cc') diff --git a/src/pipe_wrap.cc b/src/pipe_wrap.cc index 4d8f35239e3..adbeb0f8c18 100644 --- a/src/pipe_wrap.cc +++ b/src/pipe_wrap.cc @@ -4,27 +4,6 @@ #include #include -// Rules: -// -// - Do not throw from handle methods. Set errno. -// -// - MakeCallback may only be made directly off the event loop. -// That is there can be no JavaScript stack frames underneith it. -// (Is there anyway to assert that?) -// -// - No use of v8::WeakReferenceCallback. The close callback signifies that -// we're done with a handle - external resources can be freed. -// -// - Reusable? -// -// - The uv_close_cb is used to free the c++ object. The close callback -// is not made into javascript land. -// -// - uv_ref, uv_unref counts are managed at this layer to avoid needless -// js/c++ boundary crossing. At the javascript layer that should all be -// taken care of. - - #define UNWRAP \ assert(!args.Holder().IsEmpty()); \ assert(args.Holder()->InternalFieldCount() > 0); \ -- cgit v1.2.3