From b8ab49fc53b4d6c5bbae9a639103da058beaa84a Mon Sep 17 00:00:00 2001
From: Ben Noordhuis <info@bnoordhuis.nl>
Date: Sat, 22 Aug 2020 10:40:05 +0200
Subject: src: fix abort on uv_loop_init() failure

Fixes: https://github.com/nodejs/node/issues/34855

PR-URL: https://github.com/nodejs/node/pull/34874
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
---
 src/spawn_sync.cc | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

(limited to 'src')

diff --git a/src/spawn_sync.cc b/src/spawn_sync.cc
index d7d06be34bd..1141aceae98 100644
--- a/src/spawn_sync.cc
+++ b/src/spawn_sync.cc
@@ -457,9 +457,17 @@ Maybe<bool> SyncProcessRunner::TryInitializeAndRunLoop(Local<Value> options) {
     SetError(UV_ENOMEM);
     return Just(false);
   }
-  CHECK_EQ(uv_loop_init(uv_loop_), 0);
+
+  r = uv_loop_init(uv_loop_);
+  if (r < 0) {
+    delete uv_loop_;
+    uv_loop_ = nullptr;
+    SetError(r);
+    return Just(false);
+  }
 
   if (!ParseOptions(options).To(&r)) return Nothing<bool>();
+
   if (r < 0) {
     SetError(r);
     return Just(false);
-- 
cgit v1.2.3