Welcome to mirror list, hosted at ThFree Co, Russian Federation.

github.com/npm/cli.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorisaacs <i@izs.me>2012-03-13 05:49:45 +0400
committerisaacs <i@izs.me>2012-03-13 05:49:45 +0400
commitc03e41e329f50fb3cb6a40df2bb118ea71b6729f (patch)
tree44c57ac94804df3b4cd83885e88dffd912424ef4
parent2184f028232caee56a573e825e131ec8efc3186d (diff)
Fix logging around optional dependency failures
-rw-r--r--lib/install.js6
1 files changed, 4 insertions, 2 deletions
diff --git a/lib/install.js b/lib/install.js
index d2a8b0bcf..e92ef67a2 100644
--- a/lib/install.js
+++ b/lib/install.js
@@ -514,7 +514,8 @@ function targetResolver (where, context, deps) {
cache.add(what, function (er, data) {
if (er && parent && parent.optionalDependencies &&
parent.optionalDependencies.hasOwnProperty(what.split("@")[0])) {
- log.warn([target._id, er], "optional dependency failed, continuing")
+ log.warn(what, "optional dependency failed, continuing")
+ log.verbose([what, er], "optional dependency failed, continuing")
return cb(null, [])
}
@@ -547,7 +548,8 @@ function installOne (target, where, context, cb) {
// check if this one is optional to its parent.
if (er && context.parent && context.parent.optionalDependencies &&
context.parent.optionalDependencies.hasOwnProperty(target.name)) {
- log.warn([target._id, er], "optional dependency failed, continuing")
+ log.warn(target._id, "optional dependency failed, continuing")
+ log.verbose([target._id, er], "optional dependency failed, continuing")
er = null
}