unsupported: Report unsupported node versions with greater granularity

1 files changed, 21 insertions, 4 deletions

diff --git a/lib/utils/unsupported.js b/lib/utils/unsupported.js
index 91f494f4b..638410864 100644
--- a/lib/utils/unsupported.js
+++ b/lib/utils/unsupported.js
@@ -1,13 +1,18 @@
 'use strict'
 var semver = require('semver')
-var supportedNode = '>= 4'
-var knownBroken = '>=0.1 <=0.7'
+var supportedNode = [
+  {ver: '4', min: '4.7.0'},
+  {ver: '6', min: '6.0.0'},
+  {ver: '8', min: '8.0.0'}
+]
+var knownBroken = '<4.7.0'
 
 var checkVersion = exports.checkVersion = function (version) {
   var versionNoPrerelease = version.replace(/-.*$/, '')
   return {
+    version: versionNoPrerelease,
     broken: semver.satisfies(versionNoPrerelease, knownBroken),
-    unsupported: !semver.satisfies(versionNoPrerelease, supportedNode)
+    unsupported: !semver.satisfies(versionNoPrerelease, supportedNode.map(function (n) { return '^' + n.min }).join('||'))
   }
 }
 
@@ -15,8 +20,18 @@ exports.checkForBrokenNode = function () {
   var nodejs = checkVersion(process.version)
   if (nodejs.broken) {
     console.error('ERROR: npm is known not to run on Node.js ' + process.version)
+    supportedNode.forEach(function (rel) {
+      if (semver.satisfies(nodejs.version, rel.ver)) {
+        console.error('Node.js ' + rel.ver + " is supported but the specific version you're running has")
+        console.error('a bug known to break npm. Please update to at least ${rel.min} to use this')
+        console.error('version of npm. You can find the latest release of Node.js at https://nodejs.org/')
+        process.exit(1)
+      }
+    })
+    var supportedMajors = supportedNode.map(function (n) { return n.ver }).join(', ')
     console.error("You'll need to upgrade to a newer version in order to use this")
-    console.error('version of npm. You can find the latest version at https://nodejs.org/')
+    console.error('version of npm. Supported versions are ' + supportedMajors + '. You can find the')
+    console.error('latest version at https://nodejs.org/')
     process.exit(1)
   }
 }
@@ -25,9 +40,11 @@ exports.checkForUnsupportedNode = function () {
   var nodejs = checkVersion(process.version)
   if (nodejs.unsupported) {
     var log = require('npmlog')
+    var supportedMajors = supportedNode.map(function (n) { return n.ver }).join(', ')
     log.warn('npm', 'npm does not support Node.js ' + process.version)
     log.warn('npm', 'You should probably upgrade to a newer version of node as we')
     log.warn('npm', "can't make any promises that npm will work with this version.")
+    log.warn('npm', 'Supported releases of Node.js are the latest release of ' + supportedMajors + '.')
     log.warn('npm', 'You can find the latest version at https://nodejs.org/')
   }
 }