refactor and lint commands, make consistent

Still pending test coverage for most of these, but wanted to give them a
clean sweep to get the "load-all-commands" tests passing.

The following changes are in here:

- All commands now have a `completion()` method and a usage string that
  uses the same `usage` util consistently.
- The `silent` argument to many commands has been removed.
- All commands use the `cmd = ${cmd}(args).then(() => cb()).catch(cb)`
  pattern consistently.

Full test coverage for all commands is still lacking, and will have to
be done prior to the GA v7 release.

1 files changed, 14 insertions, 21 deletions

diff --git a/lib/bin.js b/lib/bin.js
index c15a7752c..e2b2a31da 100644
--- a/lib/bin.js
+++ b/lib/bin.js
@@ -1,23 +1,16 @@
-module.exports = bin
-
-var npm = require('./npm.js')
-var osenv = require('osenv')
-var output = require('./utils/output.js')
-
-bin.usage = 'npm bin [--global]'
-
-function bin (args, silent, cb) {
-  if (typeof cb !== 'function') {
-    cb = silent
-    silent = false
-  }
-  var b = npm.bin
-  var PATH = osenv.path()
-
-  if (!silent) output(b)
-  process.nextTick(cb.bind(this, null, b))
-
-  if (npm.config.get('global') && PATH.indexOf(b) === -1) {
-    process.stderr.write('(not in PATH env variable)\n')
+const osenv = require('osenv')
+const npm = require('./npm.js')
+const output = require('./utils/output.js')
+const usageUtil = require('./utils/usage.js')
+const completion = require('./utils/completion/none.js')
+const cmd = (args, cb) => bin(args).then(() => cb()).catch(cb)
+const usage = usageUtil('bin', 'npm bin [-g]')
+const bin = async (args, cb) => {
+  const b = npm.bin
+  const PATH = osenv.path()
+  output(b)
+  if (npm.flatOptions.global && !PATH.includes(b)) {
+    console.error('(not in PATH env variable)')
   }
 }
+module.exports = Object.assign(cmd, { usage, completion })