src: make the npm source comply with `standard`

This is a huge set of mostly mechanical changes. Going forward, all
changes to the npm source base are expected to comply with `standard`,
and it's been integrated into the test suite to enforce that. There are
a few notes below about specific classes of changes that need to be
handled specially for npm's code base.

standard: "Expected error to be handled."

`standard` only expects errors spelled "err" to be handled.
`npm-registry-mock` never actually invokes its callback with an error,
so in some cases I just changed it to be spelled "er" and called it
good.

standard: "Expected a "break" statement before 'case'."

This behavior is actually on purpose, and I don't feel like rewriting
the affected code right now (or, you know, ever). So I added code
comments disabling the checks in the three applicable changes.

standard: "x is a function."

Rebinding functions created via declarations (as opposed to expressions)
is a no-no?

PR-URL: https://github.com/npm/npm/pull/8668

1 files changed, 10 insertions, 7 deletions

diff --git a/lib/bin.js b/lib/bin.js
index 62922447b..2e02617d3 100644
--- a/lib/bin.js
+++ b/lib/bin.js
@@ -1,19 +1,22 @@
 module.exports = bin
 
-var npm = require("./npm.js")
-var osenv = require("osenv")
+var npm = require('./npm.js')
+var osenv = require('osenv')
 
-bin.usage = "npm bin [--global]"
+bin.usage = 'npm bin [--global]'
 
 function bin (args, silent, cb) {
-  if (typeof cb !== "function") cb = silent, silent = false
+  if (typeof cb !== 'function') {
+    cb = silent
+    silent = false
+  }
   var b = npm.bin
-    , PATH = osenv.path()
+  var PATH = osenv.path()
 
   if (!silent) console.log(b)
   process.nextTick(cb.bind(this, null, b))
 
-  if (npm.config.get("global") && PATH.indexOf(b) === -1) {
-    npm.config.get("logstream").write("(not in PATH env variable)\n")
+  if (npm.config.get('global') && PATH.indexOf(b) === -1) {
+    npm.config.get('logstream').write('(not in PATH env variable)\n')
   }
 }