src: make the npm source comply with `standard`

This is a huge set of mostly mechanical changes. Going forward, all
changes to the npm source base are expected to comply with `standard`,
and it's been integrated into the test suite to enforce that. There are
a few notes below about specific classes of changes that need to be
handled specially for npm's code base.

standard: "Expected error to be handled."

`standard` only expects errors spelled "err" to be handled.
`npm-registry-mock` never actually invokes its callback with an error,
so in some cases I just changed it to be spelled "er" and called it
good.

standard: "Expected a "break" statement before 'case'."

This behavior is actually on purpose, and I don't feel like rewriting
the affected code right now (or, you know, ever). So I added code
comments disabling the checks in the three applicable changes.

standard: "x is a function."

Rebinding functions created via declarations (as opposed to expressions)
is a no-no?

PR-URL: https://github.com/npm/npm/pull/8668

1 files changed, 15 insertions, 12 deletions

diff --git a/lib/edit.js b/lib/edit.js
index a504b10d1..155db6fd9 100644
--- a/lib/edit.js
+++ b/lib/edit.js
@@ -2,24 +2,27 @@
 // open the package folder in the $EDITOR
 
 module.exports = edit
-edit.usage = "npm edit <pkg>[@<version>]"
+edit.usage = 'npm edit <pkg>[@<version>]'
 
-edit.completion = require("./utils/completion/installed-shallow.js")
+edit.completion = require('./utils/completion/installed-shallow.js')
 
-var npm = require("./npm.js")
-  , path = require("path")
-  , fs = require("graceful-fs")
-  , editor = require("editor")
+var npm = require('./npm.js')
+var path = require('path')
+var fs = require('graceful-fs')
+var editor = require('editor')
 
 function edit (args, cb) {
   var p = args[0]
   if (args.length !== 1 || !p) return cb(edit.usage)
-  var e = npm.config.get("editor")
-  if (!e) return cb(new Error(
-    "No editor set.  Set the 'editor' config, or $EDITOR environ."))
-  p = p.split("/")
-       .join("/node_modules/")
-       .replace(/(\/node_modules)+/, "/node_modules")
+  var e = npm.config.get('editor')
+  if (!e) {
+    return cb(new Error(
+      "No editor set.  Set the 'editor' config, or $EDITOR environ."
+    ))
+  }
+  p = p.split('/')
+       .join('/node_modules/')
+       .replace(/(\/node_modules)+/, '/node_modules')
   var f = path.resolve(npm.dir, p)
   fs.lstat(f, function (er) {
     if (er) return cb(er)