diff options
author | Forrest L Norvell <forrest@npmjs.com> | 2015-06-23 08:18:52 +0300 |
---|---|---|
committer | Rebecca Turner <me@re-becca.org> | 2015-06-26 03:27:33 +0300 |
commit | b50be6aff34a739ca43de65f546e743d1a9975b9 (patch) | |
tree | 3153fd3a271245b8a05a9be196286fbe31fc9d44 /lib/install/decompose-actions.js | |
parent | 7c5ebe0552b7b5d0cdca34d28c4f16fe794ff2ff (diff) |
src: make the npm source comply with `standard`
This is a huge set of mostly mechanical changes. Going forward, all
changes to the npm source base are expected to comply with `standard`,
and it's been integrated into the test suite to enforce that. There are
a few notes below about specific classes of changes that need to be
handled specially for npm's code base.
standard: "Expected error to be handled."
`standard` only expects errors spelled "err" to be handled.
`npm-registry-mock` never actually invokes its callback with an error,
so in some cases I just changed it to be spelled "er" and called it
good.
standard: "Expected a "break" statement before 'case'."
This behavior is actually on purpose, and I don't feel like rewriting
the affected code right now (or, you know, ever). So I added code
comments disabling the checks in the three applicable changes.
standard: "x is a function."
Rebinding functions created via declarations (as opposed to expressions)
is a no-no?
PR-URL: https://github.com/npm/npm/pull/8668
Diffstat (limited to 'lib/install/decompose-actions.js')
-rw-r--r-- | lib/install/decompose-actions.js | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/lib/install/decompose-actions.js b/lib/install/decompose-actions.js index 2921fccba..b345ba5d0 100644 --- a/lib/install/decompose-actions.js +++ b/lib/install/decompose-actions.js @@ -1,9 +1,6 @@ 'use strict' -var fs = require('fs') -var path = require('path') var validate = require('aproba') var asyncMap = require('slide').asyncMap -var npm = require('../npm.js') module.exports = function (differences, decomposed, next) { validate('AAF', arguments) @@ -26,7 +23,7 @@ module.exports = function (differences, decomposed, next) { }, next) } -function addSteps(decomposed, pkg, done) { +function addSteps (decomposed, pkg, done) { decomposed.push(['fetch', pkg]) decomposed.push(['extract', pkg]) decomposed.push(['preinstall', pkg]) @@ -38,7 +35,7 @@ function addSteps(decomposed, pkg, done) { done() } -function moveSteps(decomposed, pkg, done) { +function moveSteps (decomposed, pkg, done) { decomposed.push(['move', pkg]) decomposed.push(['build', pkg]) decomposed.push(['install', pkg]) @@ -47,7 +44,7 @@ function moveSteps(decomposed, pkg, done) { done() } -function defaultSteps(decomposed, cmd, pkg, done) { +function defaultSteps (decomposed, cmd, pkg, done) { decomposed.push([cmd, pkg]) done() } |