src: make the npm source comply with `standard`

This is a huge set of mostly mechanical changes. Going forward, all
changes to the npm source base are expected to comply with `standard`,
and it's been integrated into the test suite to enforce that. There are
a few notes below about specific classes of changes that need to be
handled specially for npm's code base.

standard: "Expected error to be handled."

`standard` only expects errors spelled "err" to be handled.
`npm-registry-mock` never actually invokes its callback with an error,
so in some cases I just changed it to be spelled "er" and called it
good.

standard: "Expected a "break" statement before 'case'."

This behavior is actually on purpose, and I don't feel like rewriting
the affected code right now (or, you know, ever). So I added code
comments disabling the checks in the three applicable changes.

standard: "x is a function."

Rebinding functions created via declarations (as opposed to expressions)
is a no-no?

PR-URL: https://github.com/npm/npm/pull/8668

1 files changed, 2 insertions, 3 deletions

diff --git a/lib/install/logical-tree.js b/lib/install/logical-tree.js
index f0faf6e78..1d9492bdf 100644
--- a/lib/install/logical-tree.js
+++ b/lib/install/logical-tree.js
@@ -4,7 +4,6 @@ var union = require('lodash.union')
 var without = require('lodash.without')
 var validate = require('aproba')
 var flattenTree = require('./flatten-tree.js')
-var npm = require('../npm.js')
 var isExtraneous = require('./is-extraneous.js')
 var validateAllPeerDeps = require('./deps.js').validateAllPeerDeps
 
@@ -21,7 +20,7 @@ var logicalTree = module.exports = function (tree) {
   var flat = flattenTree(newTree)
 
   function getNode (flatname) {
-    return flatname.substr(0,5) === '#DEV:' ?
+    return flatname.substr(0, 5) === '#DEV:' ?
            flat[flatname.substr(5)] :
            flat[flatname]
   }
@@ -35,7 +34,7 @@ var logicalTree = module.exports = function (tree) {
       return parentNode.package.dependencies[node.package.name] ||
              (parentNode.package.devDependencies && parentNode.package.devDependencies[node.package.name])
     })
-    var requiredBy = requiredByNames.map(getNode)
+    requiredBy = requiredByNames.map(getNode)
 
     node.requiredBy = requiredBy