src: make the npm source comply with `standard`

This is a huge set of mostly mechanical changes. Going forward, all
changes to the npm source base are expected to comply with `standard`,
and it's been integrated into the test suite to enforce that. There are
a few notes below about specific classes of changes that need to be
handled specially for npm's code base.

standard: "Expected error to be handled."

`standard` only expects errors spelled "err" to be handled.
`npm-registry-mock` never actually invokes its callback with an error,
so in some cases I just changed it to be spelled "er" and called it
good.

standard: "Expected a "break" statement before 'case'."

This behavior is actually on purpose, and I don't feel like rewriting
the affected code right now (or, you know, ever). So I added code
comments disabling the checks in the three applicable changes.

standard: "x is a function."

Rebinding functions created via declarations (as opposed to expressions)
is a no-no?

PR-URL: https://github.com/npm/npm/pull/8668

1 files changed, 102 insertions, 83 deletions

diff --git a/lib/owner.js b/lib/owner.js
index 43076d877..f32f405dd 100644
--- a/lib/owner.js
+++ b/lib/owner.js
@@ -1,21 +1,21 @@
 module.exports = owner
 
-owner.usage = "npm owner add <user> [<@scope>/]<pkg>"
-            + "\nnpm owner rm <user> [<@scope>/]<pkg>"
-            + "\nnpm owner ls [<@scope>/]<pkg>"
+owner.usage = 'npm owner add <user> [<@scope>/]<pkg>' +
+              '\nnpm owner rm <user> [<@scope>/]<pkg>' +
+              '\nnpm owner ls [<@scope>/]<pkg>'
 
-var npm = require("./npm.js")
-  , log = require("npmlog")
-  , mapToRegistry = require("./utils/map-to-registry.js")
-  , readLocalPkg = require("./utils/read-local-package.js")
+var npm = require('./npm.js')
+var log = require('npmlog')
+var mapToRegistry = require('./utils/map-to-registry.js')
+var readLocalPkg = require('./utils/read-local-package.js')
 
 owner.completion = function (opts, cb) {
   var argv = opts.conf.argv.remain
   if (argv.length > 4) return cb()
   if (argv.length <= 2) {
-    var subs = ["add", "rm"]
-    if (opts.partialWord === "l") subs.push("ls")
-    else subs.push("ls", "list")
+    var subs = ['add', 'rm']
+    if (opts.partialWord === 'l') subs.push('ls')
+    else subs.push('ls', 'list')
     return cb(null, subs)
   }
 
@@ -25,44 +25,45 @@ owner.completion = function (opts, cb) {
     var un = encodeURIComponent(username)
     var byUser, theUser
     switch (argv[2]) {
-      case "ls":
+      case 'ls':
         // FIXME: there used to be registry completion here, but it stopped
         // making sense somewhere around 50,000 packages on the registry
         return cb()
 
-      case "rm":
+      case 'rm':
         if (argv.length > 3) {
           theUser = encodeURIComponent(argv[3])
-          byUser = "-/by-user/" + theUser + "|" + un
+          byUser = '-/by-user/' + theUser + '|' + un
           return mapToRegistry(byUser, npm.config, function (er, uri, auth) {
             if (er) return cb(er)
 
             console.error(uri)
-            npm.registry.get(uri, { auth : auth }, function (er, d) {
+            npm.registry.get(uri, { auth: auth }, function (er, d) {
               if (er) return cb(er)
               // return the intersection
               return cb(null, d[theUser].filter(function (p) {
                 // kludge for server adminery.
-                return un === "isaacs" || d[un].indexOf(p) === -1
+                return un === 'isaacs' || d[un].indexOf(p) === -1
               }))
             })
           })
         }
         // else fallthrough
-      case "add":
+        /*eslint no-fallthrough:0*/
+      case 'add':
         if (argv.length > 3) {
           theUser = encodeURIComponent(argv[3])
-          byUser = "-/by-user/" + theUser + "|" + un
+          byUser = '-/by-user/' + theUser + '|' + un
           return mapToRegistry(byUser, npm.config, function (er, uri, auth) {
             if (er) return cb(er)
 
             console.error(uri)
-            npm.registry.get(uri, { auth : auth }, function (er, d) {
+            npm.registry.get(uri, { auth: auth }, function (er, d) {
               console.error(uri, er || d)
               // return mine that they're not already on.
               if (er) return cb(er)
               var mine = d[un] || []
-                , theirs = d[theUser] || []
+              var theirs = d[theUser] || []
               return cb(null, mine.filter(function (p) {
                 return theirs.indexOf(p) === -1
               }))
@@ -70,10 +71,10 @@ owner.completion = function (opts, cb) {
           })
         }
         // just list all users who aren't me.
-        return mapToRegistry("-/users", npm.config, function (er, uri, auth) {
+        return mapToRegistry('-/users', npm.config, function (er, uri, auth) {
           if (er) return cb(er)
 
-          npm.registry.get(uri, { auth : auth }, function (er, list) {
+          npm.registry.get(uri, { auth: auth }, function (er, list) {
             if (er) return cb()
             return cb(null, Object.keys(list).filter(function (n) {
               return n !== un
@@ -90,34 +91,39 @@ owner.completion = function (opts, cb) {
 function owner (args, cb) {
   var action = args.shift()
   switch (action) {
-    case "ls": case "list": return ls(args[0], cb)
-    case "add": return add(args[0], args[1], cb)
-    case "rm": case "remove": return rm(args[0], args[1], cb)
+    case 'ls': case 'list': return ls(args[0], cb)
+    case 'add': return add(args[0], args[1], cb)
+    case 'rm': case 'remove': return rm(args[0], args[1], cb)
     default: return unknown(action, cb)
   }
 }
 
 function ls (pkg, cb) {
-  if (!pkg) return readLocalPkg(function (er, pkg) {
-    if (er) return cb(er)
-    if (!pkg) return cb(owner.usage)
-    ls(pkg, cb)
-  })
+  if (!pkg) {
+    return readLocalPkg(function (er, pkg) {
+      if (er) return cb(er)
+      if (!pkg) return cb(owner.usage)
+      ls(pkg, cb)
+    })
+  }
 
   mapToRegistry(pkg, npm.config, function (er, uri, auth) {
     if (er) return cb(er)
 
-    npm.registry.get(uri, { auth : auth }, function (er, data) {
-      var msg = ""
+    npm.registry.get(uri, { auth: auth }, function (er, data) {
+      var msg = ''
       if (er) {
-        log.error("owner ls", "Couldn't get owner data", pkg)
+        log.error('owner ls', "Couldn't get owner data", pkg)
         return cb(er)
       }
       var owners = data.maintainers
-      if (!owners || !owners.length) msg = "admin party!"
-      else msg = owners.map(function (o) {
-        return o.name + " <" + o.email + ">"
-      }).join("\n")
+      if (!owners || !owners.length) {
+        msg = 'admin party!'
+      } else {
+        msg = owners.map(function (o) {
+          return o.name + ' <' + o.email + '>'
+        }).join('\n')
+      }
       console.log(msg)
       cb(er, owners)
     })
@@ -126,20 +132,24 @@ function ls (pkg, cb) {
 
 function add (user, pkg, cb) {
   if (!user) return cb(owner.usage)
-  if (!pkg) return readLocalPkg(function (er, pkg) {
-    if (er) return cb(er)
-    if (!pkg) return cb(new Error(owner.usage))
-    add(user, pkg, cb)
-  })
+  if (!pkg) {
+    return readLocalPkg(function (er, pkg) {
+      if (er) return cb(er)
+      if (!pkg) return cb(new Error(owner.usage))
+      add(user, pkg, cb)
+    })
+  }
 
-  log.verbose("owner add", "%s to %s", user, pkg)
+  log.verbose('owner add', '%s to %s', user, pkg)
   mutate(pkg, user, function (u, owners) {
     if (!owners) owners = []
-    for (var i = 0, l = owners.length; i < l; i ++) {
+    for (var i = 0, l = owners.length; i < l; i++) {
       var o = owners[i]
       if (o.name === u.name) {
-        log.info( "owner add"
-                , "Already a package owner: " + o.name + " <" + o.email + ">")
+        log.info(
+          'owner add',
+          'Already a package owner: ' + o.name + ' <' + o.email + '>'
+        )
         return false
       }
     }
@@ -149,58 +159,69 @@ function add (user, pkg, cb) {
 }
 
 function rm (user, pkg, cb) {
-  if (!pkg) return readLocalPkg(function (er, pkg) {
-    if (er) return cb(er)
-    if (!pkg) return cb(new Error(owner.usage))
-    rm(user, pkg, cb)
-  })
+  if (!pkg) {
+    return readLocalPkg(function (er, pkg) {
+      if (er) return cb(er)
+      if (!pkg) return cb(new Error(owner.usage))
+      rm(user, pkg, cb)
+    })
+  }
 
-  log.verbose("owner rm", "%s from %s", user, pkg)
+  log.verbose('owner rm', '%s from %s', user, pkg)
   mutate(pkg, user, function (u, owners) {
     var found = false
-      , m = owners.filter(function (o) {
-          var match = (o.name === user)
-          found = found || match
-          return !match
-        })
+    var m = owners.filter(function (o) {
+      var match = (o.name === user)
+      found = found || match
+      return !match
+    })
+
     if (!found) {
-      log.info("owner rm", "Not a package owner: " + user)
+      log.info('owner rm', 'Not a package owner: ' + user)
       return false
     }
-    if (!m.length) return new Error(
-      "Cannot remove all owners of a package.  Add someone else first.")
+
+    if (!m.length) {
+      return new Error(
+        'Cannot remove all owners of a package.  Add someone else first.'
+      )
+    }
+
     return m
   }, cb)
 }
 
 function mutate (pkg, user, mutation, cb) {
   if (user) {
-    var byUser = "-/user/org.couchdb.user:" + user
+    var byUser = '-/user/org.couchdb.user:' + user
     mapToRegistry(byUser, npm.config, function (er, uri, auth) {
       if (er) return cb(er)
 
-      npm.registry.get(uri, { auth : auth }, mutate_)
+      npm.registry.get(uri, { auth: auth }, mutate_)
     })
   } else {
     mutate_(null, null)
   }
 
   function mutate_ (er, u) {
-    if (!er && user && (!u || u.error)) er = new Error(
-      "Couldn't get user data for " + user + ": " + JSON.stringify(u))
+    if (!er && user && (!u || u.error)) {
+      er = new Error(
+        "Couldn't get user data for " + user + ': ' + JSON.stringify(u)
+      )
+    }
 
     if (er) {
-      log.error("owner mutate", "Error getting user data for %s", user)
+      log.error('owner mutate', 'Error getting user data for %s', user)
       return cb(er)
     }
 
-    if (u) u = { "name" : u.name, "email" : u.email }
+    if (u) u = { name: u.name, email: u.email }
     mapToRegistry(pkg, npm.config, function (er, uri, auth) {
       if (er) return cb(er)
 
-      npm.registry.get(uri, { auth : auth }, function (er, data) {
+      npm.registry.get(uri, { auth: auth }, function (er, data) {
         if (er) {
-          log.error("owner mutate", "Error getting package data for %s", pkg)
+          log.error('owner mutate', 'Error getting package data for %s', pkg)
           return cb(er)
         }
 
@@ -213,32 +234,30 @@ function mutate (pkg, user, mutation, cb) {
         if (m instanceof Error) return cb(m) // error
 
         data = {
-          _id : data._id,
-          _rev : data._rev,
-          maintainers : m
+          _id: data._id,
+          _rev: data._rev,
+          maintainers: m
         }
-        var dataPath = pkg.replace("/", "%2f") + "/-rev/" + data._rev
+        var dataPath = pkg.replace('/', '%2f') + '/-rev/' + data._rev
         mapToRegistry(dataPath, npm.config, function (er, uri, auth) {
           if (er) return cb(er)
 
           var params = {
-            method : "PUT",
-            body : data,
-            auth : auth
+            method: 'PUT',
+            body: data,
+            auth: auth
           }
           npm.registry.request(uri, params, function (er, data) {
             if (!er && data.error) {
-              er = new Error("Failed to update package metadata: "+JSON.stringify(data))
+              er = new Error('Failed to update package metadata: ' + JSON.stringify(data))
             }
 
             if (er) {
-              log.error("owner mutate", "Failed to update package metadata")
-            }
-            else if (m.length > beforeMutation) {
-              console.log("+ %s (%s)", user, pkg)
-            }
-            else if (m.length < beforeMutation) {
-              console.log("- %s (%s)", user, pkg)
+              log.error('owner mutate', 'Failed to update package metadata')
+            } else if (m.length > beforeMutation) {
+              console.log('+ %s (%s)', user, pkg)
+            } else if (m.length < beforeMutation) {
+              console.log('- %s (%s)', user, pkg)
             }
 
             cb(er, data)
@@ -250,5 +269,5 @@ function mutate (pkg, user, mutation, cb) {
 }
 
 function unknown (action, cb) {
-  cb("Usage: \n" + owner.usage)
+  cb('Usage: \n' + owner.usage)
 }