src: make the npm source comply with `standard`

This is a huge set of mostly mechanical changes. Going forward, all
changes to the npm source base are expected to comply with `standard`,
and it's been integrated into the test suite to enforce that. There are
a few notes below about specific classes of changes that need to be
handled specially for npm's code base.

standard: "Expected error to be handled."

`standard` only expects errors spelled "err" to be handled.
`npm-registry-mock` never actually invokes its callback with an error,
so in some cases I just changed it to be spelled "er" and called it
good.

standard: "Expected a "break" statement before 'case'."

This behavior is actually on purpose, and I don't feel like rewriting
the affected code right now (or, you know, ever). So I added code
comments disabling the checks in the three applicable changes.

standard: "x is a function."

Rebinding functions created via declarations (as opposed to expressions)
is a no-no?

PR-URL: https://github.com/npm/npm/pull/8668

1 files changed, 31 insertions, 28 deletions

diff --git a/lib/pack.js b/lib/pack.js
index 1ccbd2e88..d596dd034 100644
--- a/lib/pack.js
+++ b/lib/pack.js
@@ -4,39 +4,42 @@
 
 module.exports = pack
 
-var npm = require("./npm.js")
-  , install = require("./install.js")
-  , cache = require("./cache.js")
-  , fs = require("graceful-fs")
-  , chain = require("slide").chain
-  , path = require("path")
-  , cwd = process.cwd()
-  , writeStream = require('fs-write-stream-atomic')
-  , cachedPackageRoot = require("./cache/cached-package-root.js")
+var install = require('./install.js')
+var cache = require('./cache.js')
+var fs = require('graceful-fs')
+var chain = require('slide').chain
+var path = require('path')
+var cwd = process.cwd()
+var writeStream = require('fs-write-stream-atomic')
+var cachedPackageRoot = require('./cache/cached-package-root.js')
 
-pack.usage = "npm pack [[<@scope>/]<pkg>...]"
+pack.usage = 'npm pack [[<@scope>/]<pkg>...]'
 
 // if it can be installed, it can be packed.
 pack.completion = install.completion
 
 function pack (args, silent, cb) {
-  if (typeof cb !== "function") cb = silent, silent = false
+  if (typeof cb !== 'function') {
+    cb = silent
+    silent = false
+  }
 
-  if (args.length === 0) args = ["."]
+  if (args.length === 0) args = ['.']
 
-  chain(args.map(function (arg) { return function (cb) {
-    pack_(arg, cb)
-  }}), function (er, files) {
-    if (er || silent) return cb(er, files)
-    printFiles(files, cb)
-  })
+  chain(
+    args.map(function (arg) { return function (cb) { pack_(arg, cb) } }),
+    function (er, files) {
+      if (er || silent) return cb(er, files)
+      printFiles(files, cb)
+    }
+  )
 }
 
 function printFiles (files, cb) {
   files = files.map(function (file) {
     return path.relative(cwd, file)
   })
-  console.log(files.join("\n"))
+  console.log(files.join('\n'))
   cb()
 }
 
@@ -47,17 +50,17 @@ function pack_ (pkg, cb) {
 
     // scoped packages get special treatment
     var name = data.name
-    if (name[0] === "@") name = name.substr(1).replace(/\//g, "-")
-    var fname = name + "-" + data.version + ".tgz"
+    if (name[0] === '@') name = name.substr(1).replace(/\//g, '-')
+    var fname = name + '-' + data.version + '.tgz'
 
-    var cached = path.join(cachedPackageRoot(data), "package.tgz")
-      , from = fs.createReadStream(cached)
-      , to = writeStream(fname)
-      , errState = null
+    var cached = path.join(cachedPackageRoot(data), 'package.tgz')
+    var from = fs.createReadStream(cached)
+    var to = writeStream(fname)
+    var errState = null
 
-    from.on("error", cb_)
-    to.on("error", cb_)
-    to.on("close", cb_)
+    from.on('error', cb_)
+    to.on('error', cb_)
+    to.on('close', cb_)
     from.pipe(to)
 
     function cb_ (er) {