src: make the npm source comply with `standard`

This is a huge set of mostly mechanical changes. Going forward, all
changes to the npm source base are expected to comply with `standard`,
and it's been integrated into the test suite to enforce that. There are
a few notes below about specific classes of changes that need to be
handled specially for npm's code base.

standard: "Expected error to be handled."

`standard` only expects errors spelled "err" to be handled.
`npm-registry-mock` never actually invokes its callback with an error,
so in some cases I just changed it to be spelled "er" and called it
good.

standard: "Expected a "break" statement before 'case'."

This behavior is actually on purpose, and I don't feel like rewriting
the affected code right now (or, you know, ever). So I added code
comments disabling the checks in the three applicable changes.

standard: "x is a function."

Rebinding functions created via declarations (as opposed to expressions)
is a no-no?

PR-URL: https://github.com/npm/npm/pull/8668

1 files changed, 20 insertions, 23 deletions

diff --git a/lib/repo.js b/lib/repo.js
index bbafaec3c..4bd200aff 100644
--- a/lib/repo.js
+++ b/lib/repo.js
@@ -1,14 +1,12 @@
 module.exports = repo
 
-repo.usage = "npm repo [<pkg>]"
+repo.usage = 'npm repo [<pkg>]'
 
-var npm = require("./npm.js")
-  , opener = require("opener")
-  , hostedGitInfo = require("hosted-git-info")
-  , url_ = require("url")
-  , fetchPackageMetadata = require("./fetch-package-metadata.js")
-  , mapToRegistry = require("./utils/map-to-registry.js")
-  , registry = npm.registry
+var npm = require('./npm.js')
+var opener = require('opener')
+var hostedGitInfo = require('hosted-git-info')
+var url_ = require('url')
+var fetchPackageMetadata = require('./fetch-package-metadata.js')
 
 repo.completion = function (opts, cb) {
   // FIXME: there used to be registry completion here, but it stopped making
@@ -17,8 +15,8 @@ repo.completion = function (opts, cb) {
 }
 
 function repo (args, cb) {
-  var n = args.length ? args[0] : "."
-  fetchPackageMetadata(n, ".", function (er, d) {
+  var n = args.length ? args[0] : '.'
+  fetchPackageMetadata(n, '.', function (er, d) {
     if (er) return cb(er)
     getUrlAndOpen(d, cb)
   })
@@ -26,29 +24,28 @@ function repo (args, cb) {
 
 function getUrlAndOpen (d, cb) {
   var r = d.repository
-  if (!r) return cb(new Error("no repository"))
+  if (!r) return cb(new Error('no repository'))
   // XXX remove this when npm@v1.3.10 from node 0.10 is deprecated
   // from https://github.com/npm/npm-www/issues/418
   var info = hostedGitInfo.fromUrl(r.url)
-  url = info ? info.browse() : unknownHostedUrl(r.url)
+  var url = info ? info.browse() : unknownHostedUrl(r.url)
 
-  if (!url) return cb(new Error("no repository: could not get url"))
+  if (!url) return cb(new Error('no repository: could not get url'))
 
-  opener(url, { command: npm.config.get("browser") }, cb)
+  opener(url, { command: npm.config.get('browser') }, cb)
 }
 
 function unknownHostedUrl (url) {
   try {
-    var idx = url.indexOf("@")
+    var idx = url.indexOf('@')
     if (idx !== -1) {
-      url = url.slice(idx+1).replace(/:([^\d]+)/, "/$1")
+      url = url.slice(idx + 1).replace(/:([^\d]+)/, '/$1')
     }
     url = url_.parse(url)
-    var protocol = url.protocol === "https:"
-                 ? "https:"
-                 : "http:"
-    return protocol + "//" + (url.host || "") +
-      url.path.replace(/\.git$/, "")
-  }
-  catch(e) {}
+    var protocol = url.protocol === 'https:'
+                 ? 'https:'
+                 : 'http:'
+    return protocol + '//' + (url.host || '') +
+      url.path.replace(/\.git$/, '')
+  } catch(e) {}
 }