diff options
author | isaacs <i@izs.me> | 2014-07-01 21:30:28 +0400 |
---|---|---|
committer | isaacs <i@izs.me> | 2014-07-01 21:30:33 +0400 |
commit | bea190c745f10d21cce45687298b13b6d9d7a10c (patch) | |
tree | d25ee4aa2a021a5dda3ec8b0c96417f4a0963f06 /lib/search.js | |
parent | 6e6aca8610459f3d125db1a460b9681ed6de777a (diff) |
bump nopt and npmconf
Fixes #5591
The root cause here is that a change from 022 (a number in octal literal
format) to '022' (a string) caused the string to later be interpreted as
a decimal number, making for some wacky umask values.
Solution is multipart.
First, use the actual process.umask() value from the user's environment.
This is almost certainly what they want anyway.
Second, validate all default values just like we do with user- supplied
values, rather than trusting them to never be wrong. This would've
found the problem much sooner, while in dev.
This second part requires that we allow a value of null for 'path' type
args, allow 'undefined' for the 'local-address' config, and avoid
looking up a cafile of 'null', all of which are good hygenic things to
add defense-in-depth anyway.
Diffstat (limited to 'lib/search.js')
0 files changed, 0 insertions, 0 deletions