src: make the npm source comply with `standard`

This is a huge set of mostly mechanical changes. Going forward, all
changes to the npm source base are expected to comply with `standard`,
and it's been integrated into the test suite to enforce that. There are
a few notes below about specific classes of changes that need to be
handled specially for npm's code base.

standard: "Expected error to be handled."

`standard` only expects errors spelled "err" to be handled.
`npm-registry-mock` never actually invokes its callback with an error,
so in some cases I just changed it to be spelled "er" and called it
good.

standard: "Expected a "break" statement before 'case'."

This behavior is actually on purpose, and I don't feel like rewriting
the affected code right now (or, you know, ever). So I added code
comments disabling the checks in the three applicable changes.

standard: "x is a function."

Rebinding functions created via declarations (as opposed to expressions)
is a no-no?

PR-URL: https://github.com/npm/npm/pull/8668

1 files changed, 13 insertions, 14 deletions

diff --git a/lib/star.js b/lib/star.js
index b6fc49326..29c4037d0 100644
--- a/lib/star.js
+++ b/lib/star.js
@@ -1,13 +1,12 @@
-
 module.exports = star
 
-var npm = require("./npm.js")
-  , log = require("npmlog")
-  , asyncMap = require("slide").asyncMap
-  , mapToRegistry = require("./utils/map-to-registry.js")
+var npm = require('./npm.js')
+var log = require('npmlog')
+var asyncMap = require('slide').asyncMap
+var mapToRegistry = require('./utils/map-to-registry.js')
 
-star.usage = "npm star [<pkg>...]\n"
-           + "npm unstar [<pkg>...]"
+star.usage = 'npm star [<pkg>...]\n' +
+             'npm unstar [<pkg>...]'
 
 star.completion = function (opts, cb) {
   // FIXME: there used to be registry completion here, but it stopped making
@@ -17,22 +16,22 @@ star.completion = function (opts, cb) {
 
 function star (args, cb) {
   if (!args.length) return cb(star.usage)
-  var s = npm.config.get("unicode") ? "\u2605 " : "(*)"
-    , u = npm.config.get("unicode") ? "\u2606 " : "( )"
-    , using = !(npm.command.match(/^un/))
+  var s = npm.config.get('unicode') ? '\u2605 ' : '(*)'
+  var u = npm.config.get('unicode') ? '\u2606 ' : '( )'
+  var using = !(npm.command.match(/^un/))
   if (!using) s = u
   asyncMap(args, function (pkg, cb) {
     mapToRegistry(pkg, npm.config, function (er, uri, auth) {
       if (er) return cb(er)
 
       var params = {
-        starred : using,
-        auth    : auth
+        starred: using,
+        auth: auth
       }
       npm.registry.star(uri, params, function (er, data, raw, req) {
         if (!er) {
-          console.log(s + " "+pkg)
-          log.verbose("star", data)
+          console.log(s + ' ' + pkg)
+          log.verbose('star', data)
         }
         cb(er, data, raw, req)
       })