src: make the npm source comply with `standard`

This is a huge set of mostly mechanical changes. Going forward, all
changes to the npm source base are expected to comply with `standard`,
and it's been integrated into the test suite to enforce that. There are
a few notes below about specific classes of changes that need to be
handled specially for npm's code base.

standard: "Expected error to be handled."

`standard` only expects errors spelled "err" to be handled.
`npm-registry-mock` never actually invokes its callback with an error,
so in some cases I just changed it to be spelled "er" and called it
good.

standard: "Expected a "break" statement before 'case'."

This behavior is actually on purpose, and I don't feel like rewriting
the affected code right now (or, you know, ever). So I added code
comments disabling the checks in the three applicable changes.

standard: "x is a function."

Rebinding functions created via declarations (as opposed to expressions)
is a no-no?

PR-URL: https://github.com/npm/npm/pull/8668

1 files changed, 11 insertions, 10 deletions

diff --git a/lib/substack.js b/lib/substack.js
index 1929f1873..c39a5dcc4 100644
--- a/lib/substack.js
+++ b/lib/substack.js
@@ -1,15 +1,16 @@
 module.exports = substack
-var npm = require("./npm.js")
+var npm = require('./npm.js')
 
-var isms =
-  [ "\033[32mbeep \033[35mboop\033[m"
-  , "Replace your configs with services"
-  , "SEPARATE ALL THE CONCERNS!"
-  , "MODULE ALL THE THINGS!"
-  , "\\o/"
-  , "but first, burritos"
-  , "full time mad scientist here"
-  , "c/,,\\" ]
+var isms = [
+  '\u001b[32mbeep \u001b[35mboop\u001b[m',
+  'Replace your configs with services',
+  'SEPARATE ALL THE CONCERNS!',
+  'MODULE ALL THE THINGS!',
+  '\\o/',
+  'but first, burritos',
+  'full time mad scientist here',
+  'c/,,\\'
+]
 
 function substack (args, cb) {
   var i = Math.floor(Math.random() * isms.length)