src: make the npm source comply with `standard`

This is a huge set of mostly mechanical changes. Going forward, all
changes to the npm source base are expected to comply with `standard`,
and it's been integrated into the test suite to enforce that. There are
a few notes below about specific classes of changes that need to be
handled specially for npm's code base.

standard: "Expected error to be handled."

`standard` only expects errors spelled "err" to be handled.
`npm-registry-mock` never actually invokes its callback with an error,
so in some cases I just changed it to be spelled "er" and called it
good.

standard: "Expected a "break" statement before 'case'."

This behavior is actually on purpose, and I don't feel like rewriting
the affected code right now (or, you know, ever). So I added code
comments disabling the checks in the three applicable changes.

standard: "x is a function."

Rebinding functions created via declarations (as opposed to expressions)
is a no-no?

PR-URL: https://github.com/npm/npm/pull/8668

1 files changed, 4 insertions, 4 deletions

diff --git a/lib/utils/pulse-till-done.js b/lib/utils/pulse-till-done.js
index 85fb288d1..fc6450e00 100644
--- a/lib/utils/pulse-till-done.js
+++ b/lib/utils/pulse-till-done.js
@@ -1,4 +1,4 @@
-"use strict"
+'use strict'
 var validate = require('aproba')
 var log = require('npmlog')
 
@@ -7,13 +7,13 @@ var pulse
 
 module.exports = function (prefix, cb) {
   validate('SF', [prefix, cb])
-  if (!pulsers ++) {
+  if (!pulsers++) {
     pulse = setInterval(function () {
-      log.gauge.pulse("network")
+      log.gauge.pulse('network')
     }, 250)
   }
   return function () {
-    if (!-- pulsers) {
+    if (!--pulsers) {
       clearInterval(pulse)
     }
     cb.apply(null, arguments)