de-terse the star command output picture logic

1 files changed, 8 insertions, 6 deletions

diff --git a/lib/star.js b/lib/star.js
index eec948291..b9beda0be 100644
--- a/lib/star.js
+++ b/lib/star.js
@@ -25,10 +25,12 @@ function star (args, cb) {
   const opts = npm.flatOptions
   return Promise.resolve().then(() => {
     if (!args.length) throw new Error(star.usage)
-    let s = opts.unicode ? '\u2605 ' : '(*)'
-    const u = opts.unicode ? '\u2606 ' : '( )'
-    const using = !(npm.command.match(/^un/))
-    if (!using) s = u
+    // if we're unstarring, then show an empty star image
+    // otherwise, show the full star image
+    const unstar = /^un/.test(npm.command)
+    const full = opts.unicode ? '\u2605 ' : '(*)'
+    const empty = opts.unicode ? '\u2606 ' : '( )'
+    const show = unstar ? empty : full
     return Promise.all(args.map(npa).map(pkg => {
       return Promise.all([
         getItentity(opts),
@@ -46,7 +48,7 @@ function star (args, cb) {
           users: fullData.users || {}
         }
 
-        if (using) {
+        if (!unstar) {
           log.info('star', 'starring', body._id)
           body.users[username] = true
           log.verbose('star', 'starring', body)
@@ -62,7 +64,7 @@ function star (args, cb) {
           body
         })
       }).then(data => {
-        output(s + ' ' + pkg.name)
+        output(show + ' ' + pkg.name)
         log.verbose('star', data)
         return data
       })