install/deps: Compute required package in legacy npm compatible way (#17590)

Not having this meant that uninstalls of globals installed by npm@4 or
earlier would fail, due to _requested not having the fields we expected.

PR-URL: https://github.com/npm/npm/pull/17590
Credit: @iarna
Reviewed-By: @zkat

1 files changed, 7 insertions, 2 deletions

diff --git a/lib/install/deps.js b/lib/install/deps.js
index 5aa571303..35c35dbfd 100644
--- a/lib/install/deps.js
+++ b/lib/install/deps.js
@@ -254,11 +254,16 @@ exports.loadRequestedDeps = function (args, tree, saveToDependencies, log, next)
   }, andForEachChild(loadDeps, andFinishTracker(log, next)))
 }
 
+function isNotEmpty (value) {
+  return value != null && value !== ''
+}
+
 module.exports.computeVersionSpec = computeVersionSpec
 function computeVersionSpec (tree, child) {
   validate('OO', arguments)
   var requested
-  if (child.package._requested) {
+  var childReq = child.package._requested
+  if (childReq && (isNotEmpty(childReq.saveSpec) || (isNotEmpty(childReq.rawSpec) && isNotEmpty(childReq.fetchSpec)))) {
     requested = child.package._requested
   } else if (child.package._from) {
     requested = npa(child.package._from)
@@ -277,7 +282,7 @@ function computeVersionSpec (tree, child) {
   } else if (requested.type === 'directory' || requested.type === 'file') {
     return 'file:' + path.relative(tree.path, requested.fetchSpec)
   } else {
-    return requested.saveSpec
+    return requested.saveSpec || requested.rawSpec
   }
 }