fix: consolidate split-package-names

It was only ever used by `npm edit` so it's inline now.
Rewrote `npm edit` tests to be real

2 files changed, 24 insertions, 28 deletions

diff --git a/lib/commands/edit.js b/lib/commands/edit.js
index ce74ff79b..0256f4f3a 100644
--- a/lib/commands/edit.js
+++ b/lib/commands/edit.js
@@ -3,11 +3,32 @@
 
 const { resolve } = require('path')
 const fs = require('graceful-fs')
-const { spawn } = require('child_process')
-const splitPackageNames = require('../utils/split-package-names.js')
+const cp = require('child_process')
 const completion = require('../utils/completion/installed-shallow.js')
 const BaseCommand = require('../base-command.js')
 
+const splitPackageNames = (path) => {
+  return path.split('/')
+    // combine scoped parts
+    .reduce((parts, part) => {
+      if (parts.length === 0) {
+        return [part]
+      }
+
+      const lastPart = parts[parts.length - 1]
+      // check if previous part is the first part of a scoped package
+      if (lastPart[0] === '@' && !lastPart.includes('/')) {
+        parts[parts.length - 1] += '/' + part
+      } else {
+        parts.push(part)
+      }
+
+      return parts
+    }, [])
+    .join('/node_modules/')
+    .replace(/(\/node_modules)+/, '/node_modules')
+}
+
 class Edit extends BaseCommand {
   static description = 'Edit an installed package'
   static name = 'edit'
@@ -36,7 +57,7 @@ class Edit extends BaseCommand {
           return reject(err)
         }
         const [bin, ...args] = this.npm.config.get('editor').split(/\s+/)
-        const editor = spawn(bin, [...args, dir], { stdio: 'inherit' })
+        const editor = cp.spawn(bin, [...args, dir], { stdio: 'inherit' })
         editor.on('exit', (code) => {
           if (code) {
             return reject(new Error(`editor process exited with code: ${code}`))
diff --git a/lib/utils/split-package-names.js b/lib/utils/split-package-names.js
deleted file mode 100644
index 395c2517d..000000000
--- a/lib/utils/split-package-names.js
+++ /dev/null
@@ -1,25 +0,0 @@
-'use strict'
-
-const splitPackageNames = (path) => {
-  return path.split('/')
-    // combine scoped parts
-    .reduce((parts, part) => {
-      if (parts.length === 0) {
-        return [part]
-      }
-
-      const lastPart = parts[parts.length - 1]
-      // check if previous part is the first part of a scoped package
-      if (lastPart[0] === '@' && !lastPart.includes('/')) {
-        parts[parts.length - 1] += '/' + part
-      } else {
-        parts.push(part)
-      }
-
-      return parts
-    }, [])
-    .join('/node_modules/')
-    .replace(/(\/node_modules)+/, '/node_modules')
-}
-
-module.exports = splitPackageNames