fix: empty newline printed to stderr

Starting in v7.7.0 running `npm` (no args) is printing an empty newline
to stderr.

This fixes that by correctly exiting via errorHandler and avoiding
hitting the cb() never called error and adds a test to make sure we
avoid that regression moving forward.

Fixes: https://github.com/nodejs/node/pull/37678#issuecomment-808734374

Co-authored-by: Gar <gar+gh@danger.computer>

1 files changed, 1 insertions, 3 deletions

diff --git a/lib/cli.js b/lib/cli.js
index 46859f150..f42132f94 100644
--- a/lib/cli.js
+++ b/lib/cli.js
@@ -61,9 +61,6 @@ module.exports = (process) => {
       impl(npm.argv, errorHandler)
     else {
       try {
-        // I don't know why this is needed but we get a cb() not called if we
-        // omit it
-        npm.log.level = 'silent'
         if (cmd) {
           const didYouMean = require('./utils/did-you-mean.js')
           const suggestions = await didYouMean(npm, npm.localPrefix, cmd)
@@ -71,6 +68,7 @@ module.exports = (process) => {
         } else
           npm.output(npm.usage)
         process.exitCode = 1
+        return errorHandler()
       } catch (err) {
         errorHandler(err)
       }